Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(800)

Issue 12330131: Added command-line way to close issues. (Closed)

Created:
7 years, 10 months ago by groby-ooo-7-16
Modified:
7 years, 10 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Visibility:
Public.

Description

Added command-line way to close issues. BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=184652

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M git_cl.py View 1 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
groby-ooo-7-16
Proposing a way to address the request to close from cmd line as per chromium-dev's ...
7 years, 10 months ago (2013-02-26 05:31:52 UTC) #1
M-A Ruel
lgtm https://codereview.chromium.org/12330131/diff/1/git_cl.py File git_cl.py (right): https://codereview.chromium.org/12330131/diff/1/git_cl.py#newcode1798 git_cl.py:1798: 2 lines https://codereview.chromium.org/12330131/diff/1/git_cl.py#newcode1800 git_cl.py:1800: """set the close bit""" ...
7 years, 10 months ago (2013-02-26 14:04:22 UTC) #2
groby-ooo-7-16
https://codereview.chromium.org/12330131/diff/1/git_cl.py File git_cl.py (right): https://codereview.chromium.org/12330131/diff/1/git_cl.py#newcode1798 git_cl.py:1798: On 2013/02/26 14:04:22, Marc-Antoine Ruel wrote: > 2 lines ...
7 years, 10 months ago (2013-02-26 15:06:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/12330131/4001
7 years, 10 months ago (2013-02-26 15:09:27 UTC) #4
commit-bot: I haz the power
7 years, 10 months ago (2013-02-26 15:12:03 UTC) #5
Message was sent while issue was closed.
Change committed as 184652

Powered by Google App Engine
This is Rietveld 408576698