Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 12330129: Make WaitSyncPoint go through command buffers. (Closed)

Created:
7 years, 9 months ago by piman
Modified:
7 years, 9 months ago
Reviewers:
greggman, jschuh
CC:
chromium-reviews, jam, apatrick_chromium, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Make WaitSyncPoint go through command buffers. BUG=178305 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184820

Patch Set 1 #

Patch Set 2 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+222 lines, -29 lines) Patch
M content/common/gpu/client/command_buffer_proxy_impl.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/common/gpu/client/command_buffer_proxy_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M content/common/gpu/gpu_command_buffer_stub.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/gpu_command_buffer_stub.cc View 6 chunks +9 lines, -8 lines 0 comments Download
M content/common/gpu/gpu_messages.h View 1 chunk +0 lines, -5 lines 0 comments Download
A gpu/GLES2/extensions/CHROMIUM/CHROMIUM_sync_point.txt View 1 chunk +73 lines, -0 lines 0 comments Download
M gpu/GLES2/gl2chromium_autogen.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/GLES2/gl2extchromium.h View 1 chunk +11 lines, -0 lines 0 comments Download
M gpu/command_buffer/build_gles2_cmd_buffer.py View 1 chunk +6 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_c_lib_autogen.h View 2 chunks +5 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_cmd_helper_autogen.h View 1 chunk +8 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_autogen.h View 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_impl_autogen.h View 1 chunk +7 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_unittest_autogen.h View 1 chunk +11 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_autogen.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_stub_autogen.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_stub_impl_autogen.h View 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_trace_implementation_autogen.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_trace_implementation_impl_autogen.h View 1 chunk +5 lines, -0 lines 0 comments Download
M gpu/command_buffer/cmd_buffer_functions.txt View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format_autogen.h View 1 chunk +34 lines, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format_test_autogen.h View 1 chunk +13 lines, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_ids_autogen.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.h View 2 chunks +6 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 4 chunks +17 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_mock.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_3_autogen.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
piman
gman: please review jschuh: OWNERS for gpu_messages.h (removing an IPC, moving it to command buffers).
7 years, 9 months ago (2013-02-26 01:36:43 UTC) #1
greggman
Looks like InsertSyncPointCHROMIUM is missing in cmd_buffer_functions.txt etc. no?
7 years, 9 months ago (2013-02-26 02:07:15 UTC) #2
piman
On Mon, Feb 25, 2013 at 6:07 PM, <gman@chromium.org> wrote: > Looks like InsertSyncPointCHROMIUM is ...
7 years, 9 months ago (2013-02-26 02:19:24 UTC) #3
greggman
lgtm okay then,
7 years, 9 months ago (2013-02-26 02:24:34 UTC) #4
jschuh
To expedite, it looks like you're just moving that ID from straight IPC into the ...
7 years, 9 months ago (2013-02-26 20:25:01 UTC) #5
piman
On Tue, Feb 26, 2013 at 12:25 PM, <jschuh@chromium.org> wrote: > To expedite, it looks ...
7 years, 9 months ago (2013-02-26 20:59:47 UTC) #6
jschuh
okay. not really different from a security perspective, so rubberstamp lgtm.
7 years, 9 months ago (2013-02-26 21:05:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/12330129/3001
7 years, 9 months ago (2013-02-26 21:12:16 UTC) #8
commit-bot: I haz the power
7 years, 9 months ago (2013-02-27 01:29:53 UTC) #9
Message was sent while issue was closed.
Change committed as 184820

Powered by Google App Engine
This is Rietveld 408576698