Change test_isolation_mode default from noop to check

Change test_isolation_mode default from noop to check



NOTRY=True
BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186179

[csharp, 2013-02-25 20:09:26]

I believe that everything is now listing what it uses, so these shouldn't get
called other than when there are actually getting used.

In case you think (or know) that weird places might call this, I think we could
add a generate command to isolate (basically the same as the check command, but
with the flag to ignore missing isolate files turned on).

[Marc-Antoine Ruel (Google), 2013-02-26 00:20:59]

On 2013/02/25 20:09:26, csharp wrote:
> I believe that everything is now listing what it uses, so these shouldn't get
> called other than when there are actually getting used.
> 
> In case you think (or know) that weird places might call this, I think we
could
> add a generate command to isolate (basically the same as the check command,
but
> with the flag to ignore missing isolate files turned on).

It could a GYP_DEFINE with a default value of ignoring instead of enforcing?

[csharp, 2013-02-26 16:24:07]

On 2013/02/26 00:20:59, Marc-Antoine Ruel (Google) wrote:
> On 2013/02/25 20:09:26, csharp wrote:
> > I believe that everything is now listing what it uses, so these shouldn't
get
> > called other than when there are actually getting used.
> > 
> > In case you think (or know) that weird places might call this, I think we
> could
> > add a generate command to isolate (basically the same as the check command,
> but
> > with the flag to ignore missing isolate files turned on).
> 
> It could a GYP_DEFINE with a default value of ignoring instead of enforcing?

Done, added a GYP flag that defaults to ignoring missing files.

[csharp, 2013-02-28 14:44:55]

Ok, test_mode_isolation will now stay as a noop if we aren't building inside of
chromium

[M-A Ruel, 2013-02-28 14:58:21]

+Ben

Sounds good. This should fix most of our problems. Just keep an eye in case this
break WebKit and be ready to revert.

One thing of note; this will make the try job with 'compile' in their filter to
run the check step. So this needs a PSA on chromium-dev about .isolate
maintenance.

lgtm

[commit-bot: I haz the power, 2013-03-05 15:27:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/csharp@chromium.org/12330117/17001

[commit-bot: I haz the power, 2013-03-05 15:28:08]

Change committed as 186179