Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Unified Diff: build/java_apk.gypi

Issue 12330112: Move shared lib stripping to python (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase + changes Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/strip_library_for_apk.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/java_apk.gypi
diff --git a/build/java_apk.gypi b/build/java_apk.gypi
index de475147e5a79663374f98c6ad1d48ed2b94ed15..c96012222d626470dc751f2c7a8aa49267998deb 100644
--- a/build/java_apk.gypi
+++ b/build/java_apk.gypi
@@ -85,19 +85,21 @@
'rule_name': 'copy_and_strip_native_libraries',
'extension': 'so',
'variables': {
- 'stripped_library_path': '<(PRODUCT_DIR)/<(_target_name)/libs/<(android_app_abi)/<(RULE_INPUT_ROOT).so',
+ 'apk_libraries_dir': '<(PRODUCT_DIR)/<(_target_name)/libs/<(android_app_abi)',
+ 'stripped_library_path': '<(apk_libraries_dir)/<(RULE_INPUT_ROOT).so',
},
+ 'inputs': [
+ '<(DEPTH)/build/android/strip_library_for_apk.py',
+ ],
'outputs': [
'<(stripped_library_path)',
],
- # There is no way to do 2 actions for each source library in gyp. So to
- # both strip the library and create the link in <(link_dir) a separate
- # script is required.
'action': [
- '<(DEPTH)/build/android/prepare_library_for_apk',
- '<(android_strip)',
+ 'python', '<(DEPTH)/build/android/strip_library_for_apk.py',
+ '--android-strip=<(android_strip)',
+ '--android-strip-arg=--strip-unneeded',
+ '--stripped-libraries-dir=<(apk_libraries_dir)',
'<(RULE_INPUT_PATH)',
- '<(stripped_library_path)',
],
},
],
« no previous file with comments | « build/android/strip_library_for_apk.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698