Move shared lib stripping to python

Move shared lib stripping to python

This is a pretty simple translation of the library stripping into
python. With the component build, this step will become a bit more
complex, and so I'd much rather it be in python than shell script.


BUG=158821
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186735

[Yaron, 2013-02-25 21:22:54]

lgtm

Feel free to ignore if you feel strongly but I'd prefer to limit to only options
that are needed.

https://codereview.chromium.org/12330112/diff/5/build/android/strip_library_f...
File build/android/strip_library_for_apk.py (right):

https://codereview.chromium.org/12330112/diff/5/build/android/strip_library_f...
build/android/strip_library_for_apk.py:32: parser.add_option('--libraries-dir',
action='store')
Could you os.path.dirname to get the library path, if needed (currently it
isn't)? I don't see the benefit to getting it separately.

https://codereview.chromium.org/12330112/diff/5/build/android/strip_library_f...
build/android/strip_library_for_apk.py:36: options, args = parser.parse_args()
s/args/_/

[cjhopman, 2013-03-07 01:57:26]

Probably should take another look.

Args (everything after options) are now treated as paths that needs stripping.
Also, a utility function has been pulled out into a separate file (which will be
getting more things added to it soon).

https://codereview.chromium.org/12330112/diff/5/build/android/strip_library_f...
File build/android/strip_library_for_apk.py (right):

https://codereview.chromium.org/12330112/diff/5/build/android/strip_library_f...
build/android/strip_library_for_apk.py:32: parser.add_option('--libraries-dir',
action='store')
On 2013/02/25 21:22:55, Yaron wrote:
> Could you os.path.dirname to get the library path, if needed (currently it
> isn't)? I don't see the benefit to getting it separately.

Done.

https://codereview.chromium.org/12330112/diff/5/build/android/strip_library_f...
build/android/strip_library_for_apk.py:36: options, args = parser.parse_args()
On 2013/02/25 21:22:55, Yaron wrote:
> s/args/_/

Done.

[Yaron, 2013-03-07 02:07:32]

lgtm

[commit-bot: I haz the power, 2013-03-07 15:50:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/cjhopman@chromium.org/12330112/20005

[commit-bot: I haz the power, 2013-03-07 17:39:23]

Change committed as 186735