Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12330089: JSON compiler to include "customBindings" in the function name. (Closed)

Created:
7 years, 10 months ago by SanjoyPal
Modified:
7 years, 10 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

JSON compiler to prefix the function classes by their type's names. BUG=159265 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184813

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -70 lines) Patch
M chrome/browser/extensions/api/content_settings/content_settings_api.h View 1 1 chunk +9 lines, -8 lines 0 comments Download
M chrome/browser/extensions/api/content_settings/content_settings_api.cc View 1 7 chunks +11 lines, -9 lines 0 comments Download
M chrome/browser/extensions/api/content_settings/content_settings_apitest.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/declarative/declarative_api.h View 1 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/declarative/declarative_api.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/storage/storage_api.h View 1 4 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/extensions/api/storage/storage_api.cc View 1 4 chunks +9 lines, -8 lines 0 comments Download
M chrome/common/extensions/api/content_settings.json View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/common/extensions/api/events.json View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/common/extensions/api/storage.json View 1 1 chunk +0 lines, -3 lines 0 comments Download
M tools/json_schema_compiler/cpp_bundle_generator.py View 1 2 chunks +23 lines, -16 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
SanjoyPal
PTAL. Thanks
7 years, 10 months ago (2013-02-23 00:12:32 UTC) #1
not at google - send to devlin
https://codereview.chromium.org/12330089/diff/1/tools/json_schema_compiler/model.py File tools/json_schema_compiler/model.py (right): https://codereview.chromium.org/12330089/diff/1/tools/json_schema_compiler/model.py#newcode120 tools/json_schema_compiler/model.py:120: self.custom_bindings = json.get('customBindings', None) what is this change for?
7 years, 10 months ago (2013-02-23 00:13:06 UTC) #2
SanjoyPal
https://codereview.chromium.org/12330089/diff/1/tools/json_schema_compiler/model.py File tools/json_schema_compiler/model.py (right): https://codereview.chromium.org/12330089/diff/1/tools/json_schema_compiler/model.py#newcode120 tools/json_schema_compiler/model.py:120: self.custom_bindings = json.get('customBindings', None) On 2013/02/23 00:13:07, kalman wrote: ...
7 years, 10 months ago (2013-02-23 00:19:35 UTC) #3
not at google - send to devlin
https://codereview.chromium.org/12330089/diff/1/tools/json_schema_compiler/model.py File tools/json_schema_compiler/model.py (right): https://codereview.chromium.org/12330089/diff/1/tools/json_schema_compiler/model.py#newcode120 tools/json_schema_compiler/model.py:120: self.custom_bindings = json.get('customBindings', None) On 2013/02/23 00:19:35, SanjoyPal wrote: ...
7 years, 10 months ago (2013-02-23 00:22:55 UTC) #4
SanjoyPal
On 2013/02/23 00:22:55, kalman wrote: > https://codereview.chromium.org/12330089/diff/1/tools/json_schema_compiler/model.py > File tools/json_schema_compiler/model.py (right): > > https://codereview.chromium.org/12330089/diff/1/tools/json_schema_compiler/model.py#newcode120 > ...
7 years, 10 months ago (2013-02-23 00:29:33 UTC) #5
not at google - send to devlin
Yeah, makes sense. Necessary evil I suppose.
7 years, 10 months ago (2013-02-23 00:42:09 UTC) #6
SanjoyPal
- removed the generate_type_functions compile flag - prefixed the function classes by their type's names ...
7 years, 10 months ago (2013-02-26 20:01:28 UTC) #7
not at google - send to devlin
lgtm
7 years, 10 months ago (2013-02-26 22:20:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ncj674@motorola.com/12330089/6003
7 years, 10 months ago (2013-02-26 22:44:55 UTC) #9
commit-bot: I haz the power
7 years, 10 months ago (2013-02-27 01:10:10 UTC) #10
Message was sent while issue was closed. 
Change committed as 184813

Powered by Google App Engine
This is Rietveld 408576698