Enable autofill dialog codepath on Android.

Enable autofill dialog codepath on Android.

Note that it will crash on Android if the user initiates an autocomplete
action on a rAc-enabled web-page.
There is a subseqent CL that sets up an empty shell to avoid crashes.

BUG=177508
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183997

[aruslan, 2013-02-21 22:25:58]

Please help me with the review, thanks!

[Dan Beam, 2013-02-21 22:29:01]

https://codereview.chromium.org/12330059/diff/1/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/12330059/diff/1/build/common.gypi#newcode1423
build/common.gypi:1423: }],
do we use this yet?  if not, we may as well just wait until we need it.

https://codereview.chromium.org/12330059/diff/1/chrome/renderer/chrome_render...
File chrome/renderer/chrome_render_process_observer.cc (right):

https://codereview.chromium.org/12330059/diff/1/chrome/renderer/chrome_render...
chrome/renderer/chrome_render_process_observer.cc:172: #if
ENABLE_AUTOFILL_DIALOG
should this be:

  #if defined(ENABLE_AUTOFILL_DIALOG)

or

  #if defined(ENABLE_AUTOFILL_DIALOG) && ENABLE_AUTOFILL_DIALOG

?

[aruslan, 2013-02-21 22:49:28]

Thanks, Dan, PTAL.

https://codereview.chromium.org/12330059/diff/1/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/12330059/diff/1/build/common.gypi#newcode1423
build/common.gypi:1423: }],
On 2013/02/21 22:29:01, Dan Beam wrote:
> do we use this yet?  if not, we may as well just wait until we need it.

Done.

https://codereview.chromium.org/12330059/diff/1/chrome/renderer/chrome_render...
File chrome/renderer/chrome_render_process_observer.cc (right):

https://codereview.chromium.org/12330059/diff/1/chrome/renderer/chrome_render...
chrome/renderer/chrome_render_process_observer.cc:172: #if
ENABLE_AUTOFILL_DIALOG
On 2013/02/21 22:29:01, Dan Beam wrote:
> should this be:
> 
>   #if defined(ENABLE_AUTOFILL_DIALOG)
> 
> or
> 
>   #if defined(ENABLE_AUTOFILL_DIALOG) && ENABLE_AUTOFILL_DIALOG
> 
> ?

#if defined(ENABLE_AUTOFILL_DIALOG) it is, supported 520:54 vs "#if
ENABLE_AUTOFILL_DIALOG" based on git grep | wc -l.

[aruslan, 2013-02-21 23:29:44]

sky@ -- please take a look and apply the OWNERS seal if appropriate, thanks!

[sky, 2013-02-21 23:57:05]

LGTM

[commit-bot: I haz the power, 2013-02-22 00:20:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aruslan@chromium.org/12330059/5001

[commit-bot: I haz the power, 2013-02-22 03:37:24]

Change committed as 183997