Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 12330039: Linux: Do not include CFI data in the .eh_frame section for 32-bit release builds. This reduces out… (Closed)

Created:
7 years, 10 months ago by Lei Zhang
Modified:
7 years, 10 months ago
Reviewers:
cmp, Michael Moss
CC:
chromium-reviews
Visibility:
Public.

Description

Linux: Do not include CFI data in the .eh_frame section for 32-bit release builds. This reduces output binary size and does not seem to have an affect on crash reports. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184018

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M build/common.gypi View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Lei Zhang
I chatted with ccoutant@ and he thinks we don't need the CFI data either.
7 years, 10 months ago (2013-02-21 02:10:17 UTC) #1
cmp
lgtm Also adding mmoss for FYI, possible additional review.
7 years, 10 months ago (2013-02-21 21:47:18 UTC) #2
Michael Moss
LGTM
7 years, 10 months ago (2013-02-21 21:51:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/12330039/1
7 years, 10 months ago (2013-02-21 21:53:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/12330039/1
7 years, 10 months ago (2013-02-21 22:23:44 UTC) #5
commit-bot: I haz the power
7 years, 10 months ago (2013-02-22 04:10:36 UTC) #6
Message was sent while issue was closed.
Change committed as 184018

Powered by Google App Engine
This is Rietveld 408576698