Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Unified Diff: webkit/glue/webthemeengine_impl_win.cc

Issue 12330018: Fix the size of scrollbars when using the Windows Classic theme. (Closed) Base URL: http://git.chromium.org/chromium/src.git@views-toolbar
Patch Set: Update comment. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/webthemeengine_impl_win.cc
diff --git a/webkit/glue/webthemeengine_impl_win.cc b/webkit/glue/webthemeengine_impl_win.cc
index 132345b253accc07cb8a3240e2adf0ce4d02fc35..c1c51a594c5a73a15506a27a84e0aa964b2a5fcb 100644
--- a/webkit/glue/webthemeengine_impl_win.cc
+++ b/webkit/glue/webthemeengine_impl_win.cc
@@ -10,6 +10,7 @@
#include "skia/ext/platform_canvas.h"
#include "skia/ext/skia_utils_win.h"
#include "third_party/WebKit/Source/Platform/chromium/public/WebRect.h"
+#include "ui/base/win/dpi.h"
#include "ui/native_theme/native_theme.h"
using WebKit::WebCanvas;
@@ -992,6 +993,16 @@ WebSize WebThemeEngineImpl::getSize(int part) {
ui::NativeTheme::kScrollbarUpArrow,
ui::NativeTheme::kNormal,
ui::NativeTheme::ExtraParams());
+ // GetPartSize returns a size of (0, 0) when not using a themed style
+ // (i.e. Windows Classic). Returning a non-zero size in this context
+ // creates repaint conflicts, particularly in the window titlebar area
+ // which significantly degrades performance. Fallback to using a system
+ // metric if required.
+ if (size.width() == 0) {
+ int width = static_cast<int>(GetSystemMetrics(SM_CXVSCROLL) /
+ ui::win::GetDeviceScaleFactor());
+ size = gfx::Size(width, width);
+ }
return WebSize(size.width(), size.height());
}
default:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698