[win] Clicking on the taskbar icon should hide the launcher.

[win] Clicking on the taskbar icon should hide the launcher.

This CL changes the conditions under which the launcher is kept visible
after losing focus. It now loses visibility if the taskbar gets focused
and the right mouse button is not down. This still allows right clicking
on its taskbar icon, for example to pin it, but solves the reported bug.

BUG=178902
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185192

[tapted, 2013-02-27 07:40:26]

lgtm

( Grammar fairy also has a CL description nit: "it's" -> "its". )

https://codereview.chromium.org/12326154/diff/1/chrome/browser/ui/views/app_l...
File chrome/browser/ui/views/app_list/app_list_controller_win.cc (right):

https://codereview.chromium.org/12326154/diff/1/chrome/browser/ui/views/app_l...
chrome/browser/ui/views/app_list/app_list_controller_win.cc:697: // checking
it's parent until either we find one of these windows, or there
Maybe update, "For the taskbar, ignore right-clicks only." (also grammar nit:
"it's" -> "its")

https://codereview.chromium.org/12326154/diff/1/chrome/browser/ui/views/app_l...
chrome/browser/ui/views/app_list/app_list_controller_win.cc:706: int swapped =
GetSystemMetrics(SM_SWAPBUTTON);
maybe this would be clearer like,

bool is_right_click = GetAsyncKeyState(
    (GetSystemMetrics(SM_SWAPBUTTON) ? VK_LBUTTON : VK_RBUTTON) < 0;
if (is_right_click)
  return;

[benwells, 2013-02-28 03:52:41]

Trent: I've used the lovely ? : operator, and also fixed it so it works better
(see the comment). Sorry a rebase got mixed up in it...

Please have another look.

[tapted, 2013-02-28 05:03:59]

lgtm

.. Grammar fairy still has an itch in the CL description ("it's" -> "its")

[commit-bot: I haz the power, 2013-02-28 05:06:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/benwells@chromium.org/12326154/3001

[benwells, 2013-02-28 05:20:25]

On 2013/02/28 05:03:59, tapted wrote:
> lgtm
> 
> .. Grammar fairy still has an itch in the CL description ("it's" -> "its")

Oops bug number has changed ... updating and checking box again.

[commit-bot: I haz the power, 2013-02-28 05:23:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/benwells@chromium.org/12326154/3001

[commit-bot: I haz the power, 2013-02-28 09:19:46]

Change committed as 185192