Issue 12326151: Add a way to require approval from owners other than the author.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12326151: Add a way to require approval from owners other than the author. (Closed)

Created:
7 years, 10 months ago by Dirk Pranke

Modified:
7 years, 9 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

More Reviews

Description

Add a way to require approval from owners other than the author. Right now we require approval from someone, and we require an owner approval, but we don't require an approval from an owner *other than the patch other*. It's conceivable that we might want this, so I am making this a configurable argument to the presubmit check. This will also be needed to ensure that we don't suggest you as an owner for your own patches, when we actually know who you are. R=maruel@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=185294

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+78 lines, -45 lines)			Patch
M	owners.py	View	1 2	4 chunks	+10 lines, -6 lines	0 comments	Download
M	presubmit_canned_checks.py	View	1	2 chunks	+17 lines, -12 lines	0 comments	Download
M	tests/owners_unittest.py	View		5 chunks	+26 lines, -20 lines	0 comments	Download
M	tests/presubmit_unittest.py	View	1	3 chunks	+25 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/12326151/4001

7 years, 9 months ago (2013-02-28 19:21:25 UTC) #3

Message was sent while issue was closed.

Change committed as 185294

Expand Messages | Collapse Messages

Issue 12326151: Add a way to require approval from owners other than the author. (Closed)

Description

Patch Set 1 #

Patch Set 2 : clean up naming for review #

Patch Set 3 : fix wording in comment #

Messages