chrome/common/extensions/extension.cc - Issue 12326054: *Not* allow extension features if json file fails to load

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/extension.cc

Issue 12326054: *Not* allow extension features if json file fails to load (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/extension.cc

diff --git a/chrome/common/extensions/extension.cc b/chrome/common/extensions/extension.cc

index 5cb08067560f211d0ca11ed3395aaa5f8c61480e..6dadfcd4815e01587031d41e8da61aabea207b23 100644

--- a/chrome/common/extensions/extension.cc

+++ b/chrome/common/extensions/extension.cc

@@ -603,8 +603,10 @@ bool Extension::ParsePermissions(const char* key,

// permission is added.

DCHECK(feature);

// http://crbug.com/176381

- if (!feature)

+ if (!feature) {

+ to_remove.push_back(it->id());

continue;

+ }

Feature::Availability availability =

feature->IsAvailableToManifest(

« no previous file with comments | « no previous file | no next file » | no next file with comments »