Issue 12326019: Refactor about_flags.cc to make defining enabled/disabled/default flags easier.

Issue 12326019: Refactor about_flags.cc to make defining enabled/disabled/default flags easier. (Closed)

Created:
7 years, 10 months ago by Alexei Svitkine (slow)

Modified:
7 years, 10 months ago

Reviewers:
Nico

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Refactor about_flags.cc to make defining enabled/disabled/default flags easier. BUG=177023 TEST=Unit tests. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184458

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+194 lines, -113 lines)			Patch
M	chrome/browser/about_flags.h	View	4 chunks	+21 lines, -2 lines	0 comments	Download
M	chrome/browser/about_flags.cc	View	22 chunks	+99 lines, -103 lines	0 comments	Download
M	chrome/browser/about_flags_unittest.cc	View	12 chunks	+74 lines, -8 lines	0 comments	Download

Total messages: 8 (0 generated)

Nico

lgtm On 2013/02/22 13:58:53, Alexei Svitkine wrote: > ping sorry, they made me go skiing ...

7 years, 10 months ago (2013-02-25 09:06:26 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/12326019/2008

7 years, 10 months ago (2013-02-25 15:59:23 UTC) #5

commit-bot: I haz the power

Step "update" is always a major failure. Look at the try server FAQ for more ...

7 years, 10 months ago (2013-02-25 16:57:04 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/12326019/2008

7 years, 10 months ago (2013-02-25 17:36:32 UTC) #7

Message was sent while issue was closed.

Change committed as 184458