Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1435)

Unified Diff: media/filters/video_renderer_base.cc

Issue 12324005: Fix crash in VideoRendererBase::ThreadMain(). (Closed) Base URL: http://git.chromium.org/chromium/src.git@git-svn
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/filters/video_renderer_base.h ('k') | media/filters/video_renderer_base_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/filters/video_renderer_base.cc
diff --git a/media/filters/video_renderer_base.cc b/media/filters/video_renderer_base.cc
index 37a24edd7b1fb6890baa7eeb8119f64c6faafb21..8c840c355af5acbcdf978c610ec4267b2da02ab7 100644
--- a/media/filters/video_renderer_base.cc
+++ b/media/filters/video_renderer_base.cc
@@ -45,7 +45,7 @@ VideoRendererBase::VideoRendererBase(
VideoRendererBase::~VideoRendererBase() {
base::AutoLock auto_lock(lock_);
- CHECK(state_ == kUninitialized || state_ == kStopped) << state_;
+ CHECK(state_ == kStopped || state_ == kUninitialized) << state_;
CHECK_EQ(thread_, base::kNullThreadHandle);
}
@@ -126,7 +126,12 @@ void VideoRendererBase::Stop(const base::Closure& callback) {
return;
}
- decoder_->Stop(callback);
+ if (decoder_) {
+ decoder_->Stop(callback);
+ return;
+ }
+
+ callback.Run();
}
void VideoRendererBase::StopDecoder(const base::Closure& callback) {
@@ -189,6 +194,7 @@ void VideoRendererBase::Initialize(const scoped_refptr<DemuxerStream>& stream,
error_cb_ = error_cb;
get_time_cb_ = get_time_cb;
get_duration_cb_ = get_duration_cb;
+ state_ = kInitializing;
scoped_ptr<VideoDecoderSelector> decoder_selector(
new VideoDecoderSelector(base::MessageLoopProxy::current(),
@@ -216,6 +222,8 @@ void VideoRendererBase::OnDecoderSelected(
if (state_ == kStopped)
return;
+ DCHECK_EQ(state_, kInitializing);
+
if (!selected_decoder) {
state_ = kUninitialized;
base::ResetAndReturn(&init_cb_).Run(DECODER_ERROR_NOT_SUPPORTED);
@@ -515,6 +523,7 @@ void VideoRendererBase::AttemptRead_Locked() {
return;
case kUninitialized:
+ case kInitializing:
case kPrerolled:
case kFlushingDecoder:
case kFlushed:
@@ -527,6 +536,9 @@ void VideoRendererBase::AttemptRead_Locked() {
void VideoRendererBase::OnDecoderResetDone() {
base::AutoLock auto_lock(lock_);
+ if (state_ == kStopped)
+ return;
+
DCHECK_EQ(kFlushingDecoder, state_);
DCHECK(!pending_read_);
« no previous file with comments | « media/filters/video_renderer_base.h ('k') | media/filters/video_renderer_base_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698