Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 12321143: Move cookie DB to the blocking pool. (Closed)

Created:
7 years, 9 months ago by erikwright (departed)
Modified:
7 years, 9 months ago
Reviewers:
mmenke
CC:
chromium-reviews, sail+watch_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Move ALL the cookie DBs to the blocking pool. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M chrome/browser/profiles/profile_impl_io_data.cc View 1 4 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
erikwright (departed)
7 years, 9 months ago (2013-02-26 20:22:37 UTC) #1
mmenke
https://codereview.chromium.org/12321143/diff/1/chrome/browser/profiles/profile_impl_io_data.cc File chrome/browser/profiles/profile_impl_io_data.cc (right): https://codereview.chromium.org/12321143/diff/1/chrome/browser/profiles/profile_impl_io_data.cc#newcode605 chrome/browser/profiles/profile_impl_io_data.cc:605: BrowserThread::GetBlockingPool()->GetSequenceToken()), Not the main request context?
7 years, 9 months ago (2013-02-26 21:01:18 UTC) #2
erikwright (departed)
PTAL :( https://codereview.chromium.org/12321143/diff/1/chrome/browser/profiles/profile_impl_io_data.cc File chrome/browser/profiles/profile_impl_io_data.cc (right): https://codereview.chromium.org/12321143/diff/1/chrome/browser/profiles/profile_impl_io_data.cc#newcode605 chrome/browser/profiles/profile_impl_io_data.cc:605: BrowserThread::GetBlockingPool()->GetSequenceToken()), On 2013/02/26 21:01:18, mmenke wrote: > ...
7 years, 9 months ago (2013-02-26 23:23:05 UTC) #3
mmenke
On 2013/02/26 23:23:05, erikwright wrote: > PTAL :( > > https://codereview.chromium.org/12321143/diff/1/chrome/browser/profiles/profile_impl_io_data.cc > File chrome/browser/profiles/profile_impl_io_data.cc (right): ...
7 years, 9 months ago (2013-02-26 23:50:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikwright@chromium.org/12321143/4001
7 years, 9 months ago (2013-02-27 18:09:22 UTC) #5
commit-bot: I haz the power
7 years, 9 months ago (2013-02-27 22:02:32 UTC) #6
Message was sent while issue was closed.
Change committed as 185052

Powered by Google App Engine
This is Rietveld 408576698