Issue 12321125: [Android] Remove guard that envsetup is sourced.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12321125: [Android] Remove guard that envsetup is sourced. (Closed)

Created:
7 years, 9 months ago by Yaron

Modified:
7 years, 9 months ago

Reviewers:
Isaac (away)

CC:
chromium-reviews, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Android] Remove guard that envsetup is sourced. It's breaking the webkit build of android: http://build.webkit.org/builders/Chromium%20Android%20Release/builds/34681 TBR=ilevy NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184544

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -4 lines)			Patch
	M	build/android/envsetup.sh	View		1 chunk	+7 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Yaron

Pushing through so webkit is fine on next roll. Let's investigate how to restore the ...

7 years, 9 months ago (2013-02-26 01:24:18 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/12321125/1

7 years, 9 months ago (2013-02-26 01:25:17 UTC) #2

Message was sent while issue was closed.

Change committed as 184544

Expand Messages | Collapse Messages