Move shell integration code from chrome/browser to apps

Move shell integration code from chrome/browser to apps

This code is used by core apps systems. If apps is not to depend on chrome, it
needs to move into apps.

BUG=159366

[benwells, 2013-02-25 08:09:33]

This isn't quite ready for review, it needs more deps moved over with it.

But - is the concept sound? Does this stuff belong in src/apps or should it go
somewhere deeper?

[Ben Goodger (Google), 2013-02-25 16:02:30]

I could almost see a case for some of this low level shell stuff going into
ui/base/shell_integration.

https://codereview.chromium.org/12321107/diff/1/apps/shell_integration.h
File apps/shell_integration.h (right):

https://codereview.chromium.org/12321107/diff/1/apps/shell_integration.h#newc...
apps/shell_integration.h:5: #ifndef APPS_SHELL_INTEGRATION_H_
I would consider putting this stuff in a subdir since there are so many files.

https://codereview.chromium.org/12321107/diff/1/apps/shell_integration.h#newc...
apps/shell_integration.h:31: static bool SetAsDefaultBrowserInteractive();
All of these "default browser" functions should stay in src/chrome. I don't
think they're needed here, right?

https://codereview.chromium.org/12321107/diff/1/apps/shell_integration.h#newc...
apps/shell_integration.h:84: static bool IsFirefoxDefaultBrowser();
ditto for these two methods.

https://codereview.chromium.org/12321107/diff/1/apps/shell_integration.h#newc...
apps/shell_integration.h:284: class DefaultBrowserWorker : public
DefaultWebClientWorker {
etc.

[tfarina, 2013-02-25 23:26:48]

Looks like WATCHLIST is not working :/

Otherwise I would have been copied on this CL :(

Although the following command works for me:

$ python ~/depot_tools/watchlists.py apps/

Copying myself manually so ;)

[benwells, 2013-02-26 07:33:35]

On 2013/02/25 16:02:30, Ben Goodger (Google) wrote:
> I could almost see a case for some of this low level shell stuff going into
> ui/base/shell_integration.

Yes, that's what I was thinking. After looking more I'm not so sure. I was doing
this to prepare for moving the shortcut management code out of src/chrome.
Instead of moving shell_integration first I'm going trying a different approach
of moving the shortcut manager first.

That will be in a different patch, will close this one.

> 
> https://codereview.chromium.org/12321107/diff/1/apps/shell_integration.h
> File apps/shell_integration.h (right):
> 
>
https://codereview.chromium.org/12321107/diff/1/apps/shell_integration.h#newc...
> apps/shell_integration.h:5: #ifndef APPS_SHELL_INTEGRATION_H_
> I would consider putting this stuff in a subdir since there are so many files.
> 
>
https://codereview.chromium.org/12321107/diff/1/apps/shell_integration.h#newc...
> apps/shell_integration.h:31: static bool SetAsDefaultBrowserInteractive();
> All of these "default browser" functions should stay in src/chrome. I don't
> think they're needed here, right?
> 
>
https://codereview.chromium.org/12321107/diff/1/apps/shell_integration.h#newc...
> apps/shell_integration.h:84: static bool IsFirefoxDefaultBrowser();
> ditto for these two methods.
> 
>
https://codereview.chromium.org/12321107/diff/1/apps/shell_integration.h#newc...
> apps/shell_integration.h:284: class DefaultBrowserWorker : public
> DefaultWebClientWorker {
> etc.