Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Unified Diff: chrome/installer/util/google_chrome_distribution.h

Issue 12321061: Pulling user experiment code from BrowserDistribution to a new class. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Stylistic changes; eliminating UserExperiment class in favour of namespace. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/util/google_chrome_distribution.h
diff --git a/chrome/installer/util/google_chrome_distribution.h b/chrome/installer/util/google_chrome_distribution.h
index 32bacd06250613962ca435b1c9df9d7c516fc55b..641c7233a58168cc16d9fbe25adabee35fba03f1 100644
--- a/chrome/installer/util/google_chrome_distribution.h
+++ b/chrome/installer/util/google_chrome_distribution.h
@@ -11,7 +11,6 @@
#include "base/string16.h"
#include "base/gtest_prod_util.h"
#include "chrome/installer/util/browser_distribution.h"
-#include "chrome/installer/util/util_constants.h"
namespace base {
class DictionaryValue;
@@ -87,25 +86,6 @@ class GoogleChromeDistribution : public BrowserDistribution {
installer::ArchiveType archive_type,
installer::InstallStatus install_status) OVERRIDE;
- virtual bool GetExperimentDetails(UserExperiment* experiment,
- int flavor) OVERRIDE;
-
- virtual void LaunchUserExperiment(
- const base::FilePath& setup_path,
- installer::InstallStatus status,
- const Version& version,
- const installer::Product& product,
- bool system_level) OVERRIDE;
-
- // Assuming that the user qualifies, this function performs the inactive user
- // toast experiment. It will use chrome to show the UI and it will record the
- // outcome in the registry.
- virtual void InactiveUserToastExperiment(
- int flavor,
- const string16& experiment_group,
- const installer::Product& installation,
- const base::FilePath& application_path) OVERRIDE;
-
virtual bool ShouldSetExperimentLabels() OVERRIDE;
const string16& product_guid() { return product_guid_; }

Powered by Google App Engine
This is Rietveld 408576698