Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5286)

Unified Diff: chrome/installer/util/google_chrome_distribution_dummy.cc

Issue 12321061: Pulling user experiment code from BrowserDistribution to a new class. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Adding GetUserDataPaths() to BrowserDistribution; replacing Product with other params in LaunchUser… Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/util/google_chrome_distribution_dummy.cc
diff --git a/chrome/installer/util/google_chrome_distribution_dummy.cc b/chrome/installer/util/google_chrome_distribution_dummy.cc
index 5ac90f747f318ae967e8fb06d682ac0c4cbe37d6..197d1fd1f9024776791c1f061a55a8afd1f50a41 100644
--- a/chrome/installer/util/google_chrome_distribution_dummy.cc
+++ b/chrome/installer/util/google_chrome_distribution_dummy.cc
@@ -116,6 +116,10 @@ string16 GoogleChromeDistribution::GetUninstallRegPath() {
return string16();
}
+void GetUserDataPaths(std::vector<base::FilePath>* paths) {
+ NOTREACHED();
+}
+
string16 GoogleChromeDistribution::GetVersionKey() {
NOTREACHED();
return string16();
@@ -143,26 +147,11 @@ void GoogleChromeDistribution::UpdateInstallStatus(bool system_install,
NOTREACHED();
}
-bool GoogleChromeDistribution::GetExperimentDetails(
- UserExperiment* experiment, int flavor) {
+bool GoogleChromeDistribution::ShouldSetExperimentLabels() {
NOTREACHED();
return false;
}
-void GoogleChromeDistribution::LaunchUserExperiment(
- const base::FilePath& setup_path, installer::InstallStatus status,
- const Version& version, const installer::Product& product,
- bool system_level) {
- NOTREACHED();
-}
-
-void GoogleChromeDistribution::InactiveUserToastExperiment(int flavor,
- const string16& experiment_group,
- const installer::Product& installation,
- const base::FilePath& application_path) {
- NOTREACHED();
-}
-
bool GoogleChromeDistribution::ExtractUninstallMetricsFromFile(
const base::FilePath& file_path, string16* uninstall_metrics_string) {
NOTREACHED();
@@ -181,7 +170,7 @@ bool GoogleChromeDistribution::BuildUninstallMetricsString(
return false;
}
-bool GoogleChromeDistribution::ShouldSetExperimentLabels() {
+bool GoogleChromeDistribution::HasUserExperiments() const {
NOTREACHED();
return false;
}

Powered by Google App Engine
This is Rietveld 408576698