Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5073)

Unified Diff: chrome/installer/util/google_chrome_distribution_dummy.cc

Issue 12321061: Pulling user experiment code from BrowserDistribution to a new class. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Undoing ...IfRequired() suffix; using in BrowserDistribution and Product for dispatching. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/util/google_chrome_distribution.cc ('k') | chrome/installer/util/product.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/util/google_chrome_distribution_dummy.cc
diff --git a/chrome/installer/util/google_chrome_distribution_dummy.cc b/chrome/installer/util/google_chrome_distribution_dummy.cc
index 5ac90f747f318ae967e8fb06d682ac0c4cbe37d6..0e135785592b016bdc5b329ca9690773491dd9d5 100644
--- a/chrome/installer/util/google_chrome_distribution_dummy.cc
+++ b/chrome/installer/util/google_chrome_distribution_dummy.cc
@@ -143,26 +143,11 @@ void GoogleChromeDistribution::UpdateInstallStatus(bool system_install,
NOTREACHED();
}
-bool GoogleChromeDistribution::GetExperimentDetails(
- UserExperiment* experiment, int flavor) {
+bool GoogleChromeDistribution::ShouldSetExperimentLabels() {
huangs 2013/03/04 21:47:49 This is just code movement.
NOTREACHED();
return false;
}
-void GoogleChromeDistribution::LaunchUserExperiment(
- const base::FilePath& setup_path, installer::InstallStatus status,
- const Version& version, const installer::Product& product,
- bool system_level) {
- NOTREACHED();
-}
-
-void GoogleChromeDistribution::InactiveUserToastExperiment(int flavor,
- const string16& experiment_group,
- const installer::Product& installation,
- const base::FilePath& application_path) {
- NOTREACHED();
-}
-
bool GoogleChromeDistribution::ExtractUninstallMetricsFromFile(
const base::FilePath& file_path, string16* uninstall_metrics_string) {
NOTREACHED();
@@ -180,8 +165,3 @@ bool GoogleChromeDistribution::BuildUninstallMetricsString(
NOTREACHED();
return false;
}
-
-bool GoogleChromeDistribution::ShouldSetExperimentLabels() {
- NOTREACHED();
- return false;
-}
« no previous file with comments | « chrome/installer/util/google_chrome_distribution.cc ('k') | chrome/installer/util/product.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698