chrome/installer/util/google_chrome_sxs_distribution.h - Issue 12321061: Pulling user experiment code from BrowserDistribution to a new class.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/installer/util/google_chrome_sxs_distribution.h

Issue 12321061: Pulling user experiment code from BrowserDistribution to a new class. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Style changes; removing passing of BrowserDistribution for experiments; specializing LaunchBrowserU… Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/installer/util/chrome_browser_operations.cc ('K') | « chrome/installer/util/google_chrome_distribution_dummy.cc ('k') | chrome/installer/util/google_chrome_sxs_distribution.cc » ('j') | chrome/installer/util/user_experiment.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_INSTALLER_UTIL_GOOGLE_CHROME_SXS_DISTRIBUTION_H_	5 #ifndef CHROME_INSTALLER_UTIL_GOOGLE_CHROME_SXS_DISTRIBUTION_H_

6 #define CHROME_INSTALLER_UTIL_GOOGLE_CHROME_SXS_DISTRIBUTION_H_	6 #define CHROME_INSTALLER_UTIL_GOOGLE_CHROME_SXS_DISTRIBUTION_H_

7	7

8 #include "base/string16.h"	8 #include "base/string16.h"

9 #include "chrome/installer/util/browser_distribution.h"	9 #include "chrome/installer/util/browser_distribution.h"

10 #include "chrome/installer/util/google_chrome_distribution.h"	10 #include "chrome/installer/util/google_chrome_distribution.h"

(...skipping 13 matching lines...) Expand all Loading...
24 virtual string16 GetBaseAppId() OVERRIDE;	24 virtual string16 GetBaseAppId() OVERRIDE;

25 virtual string16 GetInstallSubDir() OVERRIDE;	25 virtual string16 GetInstallSubDir() OVERRIDE;

26 virtual string16 GetUninstallRegPath() OVERRIDE;	26 virtual string16 GetUninstallRegPath() OVERRIDE;

27 virtual bool CanSetAsDefault() OVERRIDE;	27 virtual bool CanSetAsDefault() OVERRIDE;

28 virtual int GetIconIndex() OVERRIDE;	28 virtual int GetIconIndex() OVERRIDE;

29 virtual bool GetChromeChannel(string16* channel) OVERRIDE;	29 virtual bool GetChromeChannel(string16* channel) OVERRIDE;

30 virtual bool GetCommandExecuteImplClsid(	30 virtual bool GetCommandExecuteImplClsid(

31 string16* handler_class_uuid) OVERRIDE;	31 string16* handler_class_uuid) OVERRIDE;

32 virtual bool AppHostIsSupported() OVERRIDE;	32 virtual bool AppHostIsSupported() OVERRIDE;

33 virtual bool ShouldSetExperimentLabels() OVERRIDE;	33 virtual bool ShouldSetExperimentLabels() OVERRIDE;

	34 virtual bool HasUserExperiments() OVERRIDE;

34 // returns the channel name for GoogleChromeSxSDistribution	35 // returns the channel name for GoogleChromeSxSDistribution

35 static string16 ChannelName();	36 static string16 ChannelName();

36 private:	37 private:

37 friend class BrowserDistribution;	38 friend class BrowserDistribution;

38	39

39 // Disallow construction from non-friends.	40 // Disallow construction from non-friends.

40 GoogleChromeSxSDistribution();	41 GoogleChromeSxSDistribution();

41 };	42 };

42	43

43 #endif // CHROME_INSTALLER_UTIL_GOOGLE_CHROME_SXS_DISTRIBUTION_H_	44 #endif // CHROME_INSTALLER_UTIL_GOOGLE_CHROME_SXS_DISTRIBUTION_H_

OLD	NEW