Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Side by Side Diff: chrome/installer/util/chrome_app_host_operations.cc

Issue 12321061: Pulling user experiment code from BrowserDistribution to a new class. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Adding GetUserDataPaths() to BrowserDistribution; replacing Product with other params in LaunchUser… Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/installer/util/chrome_app_host_operations.h" 5 #include "chrome/installer/util/chrome_app_host_operations.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/files/file_path.h" 8 #include "base/files/file_path.h"
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "chrome/common/chrome_switches.h" 10 #include "chrome/common/chrome_switches.h"
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
113 if (!properties->has_icon()) 113 if (!properties->has_icon())
114 properties->set_icon(target_exe, dist->GetIconIndex()); 114 properties->set_icon(target_exe, dist->GetIconIndex());
115 115
116 if (!properties->has_app_id()) { 116 if (!properties->has_app_id()) {
117 std::vector<string16> components; 117 std::vector<string16> components;
118 components.push_back(dist->GetBaseAppId()); 118 components.push_back(dist->GetBaseAppId());
119 properties->set_app_id(ShellUtil::BuildAppModelId(components)); 119 properties->set_app_id(ShellUtil::BuildAppModelId(components));
120 } 120 }
121 } 121 }
122 122
123 void ChromeAppHostOperations::LaunchUserExperiment(
124 const base::FilePath& setup_path,
125 const std::set<std::wstring>& options,
126 BrowserDistribution* dist,
127 InstallStatus status,
128 bool system_level) const {
129 NOTREACHED() << "Chrome App Launcher does not launch user experiments.";
grt (UTC plus 2) 2013/03/12 14:32:18 please switch to: // Explanatory comment. NOTR
huangs 2013/03/12 18:03:07 Done.
130 }
131
123 } // namespace installer 132 } // namespace installer
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698