chrome/installer/util/chrome_frame_operations.h - Issue 12321061: Pulling user experiment code from BrowserDistribution to a new class.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/installer/util/chrome_frame_operations.h

Issue 12321061: Pulling user experiment code from BrowserDistribution to a new class. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Undoing ...IfRequired() suffix; using in BrowserDistribution and Product for dispatching. Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/installer/util/chrome_browser_sxs_operations.cc ('k') | chrome/installer/util/chrome_frame_operations.cc » ('j') | chrome/installer/util/google_chrome_distribution_dummy.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_INSTALLER_UTIL_CHROME_FRAME_OPERATIONS_H_	5 #ifndef CHROME_INSTALLER_UTIL_CHROME_FRAME_OPERATIONS_H_

6 #define CHROME_INSTALLER_UTIL_CHROME_FRAME_OPERATIONS_H_	6 #define CHROME_INSTALLER_UTIL_CHROME_FRAME_OPERATIONS_H_

7	7

8 #include "base/basictypes.h"	8 #include "base/basictypes.h"

9 #include "base/compiler_specific.h"	9 #include "base/compiler_specific.h"

10 #include "chrome/installer/util/product_operations.h"	10 #include "chrome/installer/util/product_operations.h"

(...skipping 32 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
43 ChannelInfo* channel_info) const OVERRIDE;	43 ChannelInfo* channel_info) const OVERRIDE;

44	44

45 virtual bool ShouldCreateUninstallEntry(	45 virtual bool ShouldCreateUninstallEntry(

46 const std::set<std::wstring>& options) const OVERRIDE;	46 const std::set<std::wstring>& options) const OVERRIDE;

47	47

48 virtual void AddDefaultShortcutProperties(	48 virtual void AddDefaultShortcutProperties(

49 BrowserDistribution* dist,	49 BrowserDistribution* dist,

50 const base::FilePath& target_exe,	50 const base::FilePath& target_exe,

51 ShellUtil::ShortcutProperties* properties) const OVERRIDE;	51 ShellUtil::ShortcutProperties* properties) const OVERRIDE;

52	52

	53 virtual bool ShouldLaunchUserExperiment() const OVERRIDE;

	54

53 protected:	55 protected:

54 void NormalizeOptions(std::set<std::wstring>* options) const;	56 void NormalizeOptions(std::set<std::wstring>* options) const;

55	57

56 private:	58 private:

57 DISALLOW_COPY_AND_ASSIGN(ChromeFrameOperations);	59 DISALLOW_COPY_AND_ASSIGN(ChromeFrameOperations);

58 };	60 };

59	61

60 } // namespace installer	62 } // namespace installer

61	63

62 #endif // CHROME_INSTALLER_UTIL_CHROME_FRAME_OPERATIONS_H_	64 #endif // CHROME_INSTALLER_UTIL_CHROME_FRAME_OPERATIONS_H_

OLD	NEW