chrome/test/chromedriver/net/test_http_server.cc - Issue 12321057: [chromedriver] Implement reconnection to DevTools.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/net/test_http_server.cc

Issue 12321057: [chromedriver] Implement reconnection to DevTools. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix nits. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/chromedriver/net/test_http_server.cc

diff --git a/chrome/test/chromedriver/net/test_http_server.cc b/chrome/test/chromedriver/net/test_http_server.cc

index b2780871d9dc4e456a9926f66c2a6d0fd5be4e66..7946bae381cb9d43587e8c6d33739972b122b78b 100644

--- a/chrome/test/chromedriver/net/test_http_server.cc

+++ b/chrome/test/chromedriver/net/test_http_server.cc

@@ -43,12 +43,15 @@ bool TestHttpServer::Start() {

}

void TestHttpServer::Stop() {

+ if (!thread_.IsRunning())

+ return;

base::WaitableEvent event(false, false);

thread_.message_loop_proxy()->PostTask(

FROM_HERE,

base::Bind(&TestHttpServer::StopOnServerThread,

base::Unretained(this), &event));

event.Wait();

+ thread_.Stop();

}

bool TestHttpServer::WaitForConnectionsToClose() {