Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Unified Diff: chrome/test/chromedriver/devtools_client_impl.h

Issue 12321057: [chromedriver] Implement reconnection to DevTools. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix nits. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/devtools_client.h ('k') | chrome/test/chromedriver/devtools_client_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/devtools_client_impl.h
diff --git a/chrome/test/chromedriver/devtools_client_impl.h b/chrome/test/chromedriver/devtools_client_impl.h
index c496c0f30714b1737a08376685e261ee4661dbaa..4bcfcca7ceaeb49ce41963028f6d49a74a11923c 100644
--- a/chrome/test/chromedriver/devtools_client_impl.h
+++ b/chrome/test/chromedriver/devtools_client_impl.h
@@ -51,8 +51,10 @@ class SyncWebSocket;
class DevToolsClientImpl : public DevToolsClient {
public:
+ typedef base::Callback<Status()> FrontendCloserFunc;
DevToolsClientImpl(const SyncWebSocketFactory& factory,
- const std::string& url);
+ const std::string& url,
+ const FrontendCloserFunc& frontend_closer_func);
typedef base::Callback<bool(
const std::string&,
@@ -62,6 +64,7 @@ class DevToolsClientImpl : public DevToolsClient {
internal::InspectorCommandResponse*)> ParserFunc;
DevToolsClientImpl(const SyncWebSocketFactory& factory,
const std::string& url,
+ const FrontendCloserFunc& frontend_closer_func,
const ParserFunc& parser_func);
virtual ~DevToolsClientImpl();
@@ -69,6 +72,7 @@ class DevToolsClientImpl : public DevToolsClient {
void SetParserFuncForTesting(const ParserFunc& parser_func);
// Overridden from DevToolsClient:
+ virtual Status ConnectIfNecessary() OVERRIDE;
virtual Status SendCommand(const std::string& method,
const base::DictionaryValue& params) OVERRIDE;
virtual Status SendCommandAndGetResult(
@@ -97,12 +101,12 @@ class DevToolsClientImpl : public DevToolsClient {
const base::DictionaryValue& params);
scoped_ptr<SyncWebSocket> socket_;
GURL url_;
+ FrontendCloserFunc frontend_closer_func_;
ParserFunc parser_func_;
std::list<DevToolsEventListener*> listeners_;
std::list<DevToolsEventListener*> listeners_for_on_connected_;
typedef std::map<int, base::DictionaryValue*> ResponseMap;
ResponseMap cmd_response_map_;
- bool connected_;
int next_id_;
DISALLOW_COPY_AND_ASSIGN(DevToolsClientImpl);
« no previous file with comments | « chrome/test/chromedriver/devtools_client.h ('k') | chrome/test/chromedriver/devtools_client_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698