Issue 12321047: Fix windows build warnings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12321047: Fix windows build warnings. (Closed)

Created:
7 years, 10 months ago by Yang

Modified:
7 years, 10 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix windows build warnings. R=jkummerow@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=13707

Patch Set 1 #

Total comments: 1

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -4 lines)			Patch
	M	src/hydrogen-instructions.cc	View		1 chunk	+2 lines, -4 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM. https://chromiumcodereview.appspot.com/12321047/diff/1/src/hydrogen-instructions.cc File src/hydrogen-instructions.cc (right): https://chromiumcodereview.appspot.com/12321047/diff/1/src/hydrogen-instructions.cc#newcode2790 src/hydrogen-instructions.cc:2790: new(zone) HConstant(static_cast<double>(val), Representation::Double()) I don't think this cast ...

7 years, 10 months ago (2013-02-21 12:17:04 UTC) #2

Yang

7 years, 10 months ago (2013-02-21 12:17:53 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r13707 (presubmit successful).

Expand Messages | Collapse Messages