Issue 12320097: Android / Telemetry: fixes surface stats collector.

Issue 12320097: Android / Telemetry: fixes surface stats collector. (Closed)

Created:
7 years, 10 months ago by bulach

Modified:
7 years, 10 months ago

Reviewers:
Sami, marja

CC:
chromium-reviews, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Android / Telemetry: fixes surface stats collector. The surface stats collector runs on a separate thread, which potentially outlives the underlying app. Make it more graceful on this case rather than assert it always fetches results. BUG= TEST= NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184632

Patch Set 1 : Patch #

Patch Set 2 : try..finally and a few more fixes #

Total comments: 1

Patch Set 3 : Nits #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -26 lines)			Patch
	M	build/android/pylib/surface_stats_collector.py	View	1 2	3 chunks	+21 lines, -5 lines	0 comments	Download
	M	tools/telemetry/telemetry/page/scrolling_action.py	View	1	1 chunk	+23 lines, -21 lines	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

Sami

lgtm, thanks. https://codereview.chromium.org/12320097/diff/5001/build/android/pylib/surface_stats_collector.py File build/android/pylib/surface_stats_collector.py (right): https://codereview.chromium.org/12320097/diff/5001/build/android/pylib/surface_stats_collector.py#newcode171 build/android/pylib/surface_stats_collector.py:171: The tuple maybe (None, None) if there ...

7 years, 10 months ago (2013-02-25 19:02:53 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/12320097/5002

7 years, 10 months ago (2013-02-26 12:08:05 UTC) #6

marja

Does the commit bot run any interesting try jobs nowadays? If not, you might want ...

7 years, 10 months ago (2013-02-26 12:13:51 UTC) #7

bulach

oh, yeah, that's a good point, thanks marja! next patch I'll add the NOTRY, I ...

7 years, 10 months ago (2013-02-26 12:22:05 UTC) #8

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/12320097/5002

7 years, 10 months ago (2013-02-26 12:27:39 UTC) #9

Message was sent while issue was closed.

Change committed as 184632

Expand Messages | Collapse Messages