Issue 12320064: Fix prefs registration in promo code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12320064: Fix prefs registration in promo code. (Closed)

Created:
7 years, 10 months ago by Jói

Modified:
7 years, 10 months ago

Reviewers:
Dan Beam, Mattias Nissler (ping if slow)

CC:
chromium-reviews, achuithb

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Fix prefs registration in promo code. All preferences should be registered _before_ a PrefService is created, so reading other prefs during registration is a no-no. BUG=155525 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184473

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -17 lines)			Patch
M	chrome/browser/prefs/browser_prefs.cc	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/web_resource/notification_promo.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/web_resource/notification_promo.cc	View		1 chunk	+8 lines, -5 lines	0 comments	Download
M	chrome/browser/web_resource/promo_resource_service.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/web_resource/promo_resource_service.cc	View		1 chunk	+10 lines, -7 lines	0 comments	Download

Total messages: 5 (0 generated)

Jói

mnissler: Entire change. dbeam: FYI re change in how migration is done. I may TBR ...

7 years, 10 months ago (2013-02-22 12:15:21 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/12320064/10002

7 years, 10 months ago (2013-02-25 16:04:02 UTC) #4

Message was sent while issue was closed.

Change committed as 184473