Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1110)

Issue 12320064: Fix prefs registration in promo code. (Closed)

Created:
7 years, 10 months ago by Jói
Modified:
7 years, 10 months ago
CC:
chromium-reviews, achuithb
Visibility:
Public.

Description

Fix prefs registration in promo code. All preferences should be registered _before_ a PrefService is created, so reading other prefs during registration is a no-no. BUG=155525 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184473

Patch Set 1 #

Patch Set 2 : Merge LKGR #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -17 lines) Patch
M chrome/browser/prefs/browser_prefs.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/web_resource/notification_promo.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/web_resource/notification_promo.cc View 1 chunk +8 lines, -5 lines 0 comments Download
M chrome/browser/web_resource/promo_resource_service.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/web_resource/promo_resource_service.cc View 1 chunk +10 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Jói
mnissler: Entire change. dbeam: FYI re change in how migration is done. I may TBR ...
7 years, 10 months ago (2013-02-22 12:15:21 UTC) #1
Mattias Nissler (ping if slow)
LGTM
7 years, 10 months ago (2013-02-22 13:10:51 UTC) #2
Dan Beam
lgtm (cool!)
7 years, 10 months ago (2013-02-22 20:28:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/12320064/10002
7 years, 10 months ago (2013-02-25 16:04:02 UTC) #4
commit-bot: I haz the power
7 years, 10 months ago (2013-02-25 20:50:53 UTC) #5
Message was sent while issue was closed.
Change committed as 184473

Powered by Google App Engine
This is Rietveld 408576698