Issue 12320047: pkg-config-wrapper shouldn't clobber PKG_CONFIG_PATH if it is already set

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12320047: pkg-config-wrapper shouldn't clobber PKG_CONFIG_PATH if it is already set (Closed)

Created:
7 years, 10 months ago by Mostyn Bramley-Moore

Modified:
7 years, 10 months ago

Reviewers:
piman

CC:
chromium-reviews, Mostyn Bramley-Moore, Daniel Bratell

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

pkg-config-wrapper shouldn't clobber PKG_CONFIG_PATH if it is already set This allows cross-compilation using sysroots with pkgconfig directories in non-standard locations. Add Opera Software to the AUTHORS file BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183957

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -1 line)			Patch
	M	AUTHORS	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	build/linux/pkg-config-wrapper	View		1 chunk	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Mostyn Bramley-Moore

Re-uploaded using my @opera.com account, the original issue was here: https://codereview.chromium.org/12318018/

7 years, 10 months ago (2013-02-21 20:41:42 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/12320047/1

7 years, 10 months ago (2013-02-21 20:46:54 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/12320047/1

7 years, 10 months ago (2013-02-21 22:19:31 UTC) #4

Message was sent while issue was closed.

Change committed as 183957

Expand Messages | Collapse Messages