Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 12320043: Fix git-crup errors when CDPATH is set. (Closed)

Created:
7 years, 10 months ago by justinlin
Modified:
7 years, 10 months ago
Reviewers:
szager1
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Visibility:
Public.

Description

Fix git-crup errors when CDPATH is set. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=184148

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M crup-runner.sh View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
justinlin
Hi Stefan, ptal. I found that git-crup never runs without error, so it won't runhooks ...
7 years, 10 months ago (2013-02-21 18:26:29 UTC) #1
justinlin
updated patch per your observations
7 years, 10 months ago (2013-02-22 00:19:29 UTC) #2
szager1
lgtm, thanks!
7 years, 10 months ago (2013-02-22 19:22:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/justinlin@chromium.org/12320043/3002
7 years, 10 months ago (2013-02-22 19:26:10 UTC) #4
commit-bot: I haz the power
7 years, 10 months ago (2013-02-22 19:28:24 UTC) #5
Message was sent while issue was closed.
Change committed as 184148

Powered by Google App Engine
This is Rietveld 408576698