Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(884)

Unified Diff: sync/engine/sync_session_job.h

Issue 12320027: Remove SyncSessionJob's location member (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/engine/sync_scheduler_whitebox_unittest.cc ('k') | sync/engine/sync_session_job.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/engine/sync_session_job.h
diff --git a/sync/engine/sync_session_job.h b/sync/engine/sync_session_job.h
index 9fe036170757549728b17d9d61b2f040c4300c88..64ad1c6349fc3c316786fd9f60850a5aab64521c 100644
--- a/sync/engine/sync_session_job.h
+++ b/sync/engine/sync_session_job.h
@@ -8,7 +8,6 @@
#include "base/memory/scoped_ptr.h"
#include "base/memory/weak_ptr.h"
#include "base/time.h"
-#include "base/tracked_objects.h"
#include "sync/base/sync_export.h"
#include "sync/engine/sync_scheduler.h"
#include "sync/engine/syncer.h"
@@ -42,8 +41,7 @@ class SYNC_EXPORT_PRIVATE SyncSessionJob {
SyncSessionJob(Purpose purpose,
base::TimeTicks start,
scoped_ptr<sessions::SyncSession> session,
- const ConfigurationParams& config_params,
- const tracked_objects::Location& nudge_location);
+ const ConfigurationParams& config_params);
~SyncSessionJob();
// Returns a new clone of the job, with a cloned SyncSession ready to be
@@ -52,8 +50,6 @@ class SYNC_EXPORT_PRIVATE SyncSessionJob {
// to prevent bugs where multiple jobs are scheduled with the same session.
// Use CloneAndAbandon if you want to clone before finishing.
scoped_ptr<SyncSessionJob> Clone() const;
- scoped_ptr<SyncSessionJob> CloneFromLocation(
- const tracked_objects::Location& from_here) const;
// Same as Clone() above, but also ejects the SyncSession from this job,
// preventing it from ever being used for a sync cycle.
@@ -89,7 +85,6 @@ class SYNC_EXPORT_PRIVATE SyncSessionJob {
void set_scheduled_start(base::TimeTicks start);
const sessions::SyncSession* session() const;
sessions::SyncSession* mutable_session();
- const tracked_objects::Location& from_location() const;
SyncerStep start_step() const;
SyncerStep end_step() const;
ConfigurationParams config_params() const;
@@ -122,11 +117,6 @@ class SYNC_EXPORT_PRIVATE SyncSessionJob {
// all requisite steps given |purpose_| without being preempted.
FinishedState finished_;
- // This is the location the job came from. Used for debugging.
- // In case of multiple nudges getting coalesced this stores the
- // first location that came in.
- tracked_objects::Location from_location_;
-
base::WeakPtr<DestructionObserver> destruction_observer_;
DISALLOW_COPY_AND_ASSIGN(SyncSessionJob);
« no previous file with comments | « sync/engine/sync_scheduler_whitebox_unittest.cc ('k') | sync/engine/sync_session_job.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698