Issue 12319138: Make chrome.filesystem API fully work with the Chrome OS Google Drive folder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12319138: Make chrome.filesystem API fully work with the Chrome OS Google Drive folder. (Closed)

Created:
7 years, 9 months ago by kinaba

Modified:
7 years, 9 months ago

Reviewers:
benwells

CC:
chromium-reviews, tzik+watch_chromium.org, jam, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, kinuko+watch, stevenjb+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Make chrome.filesystem API fully work with the Chrome OS Google Drive folder. BUG=156277 TEST=Launch sample text editor of chrome.filesystem. Use open/save dialog on Drive files. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190461

Patch Set 1 : #

Patch Set 2 : for running test (actual patch needs rebasing) #

Patch Set 3 : Rebase. #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -20 lines)			Patch
	M	chrome/browser/extensions/api/file_system/file_system_api.h	View	1 2	1 chunk	+4 lines, -3 lines	0 comments	Download
	M	chrome/browser/extensions/api/file_system/file_system_api.cc	View	1 2	6 chunks	+39 lines, -17 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

kinaba

Over https://codereview.chromium.org/13023002/. This should be the last piece.

7 years, 9 months ago (2013-03-22 10:56:56 UTC) #1

kinaba

On 2013/03/24 05:22:25, benwells wrote: > lgtm. > > Is it possible to test this ...

7 years, 9 months ago (2013-03-24 23:18:42 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/12319138/20001

7 years, 9 months ago (2013-03-25 14:49:48 UTC) #4

Message was sent while issue was closed.

Change committed as 190461

Expand Messages | Collapse Messages