Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Unified Diff: content/browser/devtools/devtools_http_handler_impl.h

Issue 12319114: Extract debugger target enumeration into a separate class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@debugger
Patch Set: Rebase Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/devtools_http_handler_impl.h
diff --git a/content/browser/devtools/devtools_http_handler_impl.h b/content/browser/devtools/devtools_http_handler_impl.h
index dd027eee63bd150f8d929591f5a981b9d02e8d2f..77d7283c09ba5322f292d1751a6219aa40ab6ecc 100644
--- a/content/browser/devtools/devtools_http_handler_impl.h
+++ b/content/browser/devtools/devtools_http_handler_impl.h
@@ -41,13 +41,9 @@ class DevToolsHttpHandlerImpl
public base::RefCountedThreadSafe<DevToolsHttpHandlerImpl>,
public net::HttpServer::Delegate {
private:
- struct PageInfo;
- typedef std::vector<PageInfo> PageList;
friend class base::RefCountedThreadSafe<DevToolsHttpHandlerImpl>;
friend class DevToolsHttpHandler;
- static bool SortPageListByTime(const PageInfo& info1, const PageInfo& info2);
-
// Takes ownership over |socket_factory|.
DevToolsHttpHandlerImpl(const net::StreamListenSocketFactory* socket_factory,
const std::string& frontend_url,
@@ -78,8 +74,7 @@ class DevToolsHttpHandlerImpl
void OnJsonRequestUI(int connection_id,
const net::HttpServerRequestInfo& info);
- void OnThumbnailRequestUI(int connection_id,
- const net::HttpServerRequestInfo& info);
+ void OnThumbnailRequestUI(int connection_id, const GURL& page_url);
void OnDiscoveryPageRequestUI(int connection_id);
void OnWebSocketRequestUI(int connection_id,
@@ -110,16 +105,11 @@ class DevToolsHttpHandlerImpl
void AcceptWebSocket(int connection_id,
const net::HttpServerRequestInfo& request);
- PageList GeneratePageList();
-
// Returns the front end url without the host at the beginning.
std::string GetFrontendURLInternal(const std::string rvh_id,
const std::string& host);
- PageInfo CreatePageInfo(RenderViewHost* rvh,
- DevToolsHttpHandlerDelegate::TargetType type);
-
- base::DictionaryValue* SerializePageInfo(const PageInfo& page_info,
+ base::DictionaryValue* SerializePageInfo(RenderViewHost* rvh,
const std::string& host);
// The thread used by the devtools handler to run server socket.
« no previous file with comments | « content/browser/devtools/devtools_agent_host_impl.cc ('k') | content/browser/devtools/devtools_http_handler_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698