Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2523)

Unified Diff: chrome/browser/extensions/extension_service.cc

Issue 12319114: Extract debugger target enumeration into a separate class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@debugger
Patch Set: Rebase Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_service.h ('k') | chrome/test/data/devtools/target_list/background.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_service.cc
diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc
index ebe016bf4b77bd44c193f0261048852e67ab0e0b..a041040b978c9421b524848464d2046d848942e2 100644
--- a/chrome/browser/extensions/extension_service.cc
+++ b/chrome/browser/extensions/extension_service.cc
@@ -728,9 +728,9 @@ void ExtensionService::ReloadExtensionWithEvents(
manager->GetBackgroundHostForExtension(extension_id);
if (host && DevToolsAgentHost::HasFor(host->render_view_host())) {
// Look for an open inspector for the background page.
- int devtools_cookie = DevToolsAgentHost::DisconnectRenderViewHost(
+ std::string devtools_cookie = DevToolsAgentHost::DisconnectRenderViewHost(
host->render_view_host());
- if (devtools_cookie >= 0)
+ if (devtools_cookie != std::string())
orphaned_dev_tools_[extension_id] = devtools_cookie;
}
« no previous file with comments | « chrome/browser/extensions/extension_service.h ('k') | chrome/test/data/devtools/target_list/background.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698