Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Unified Diff: content/browser/devtools/devtools_agent_host_impl.h

Issue 12319114: Extract debugger target enumeration into a separate class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@debugger
Patch Set: Cleaner version ready for review Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/devtools_agent_host_impl.h
diff --git a/content/browser/devtools/devtools_agent_host_impl.h b/content/browser/devtools/devtools_agent_host_impl.h
index c3a52155f91294dd70f9fa3cab7d31f258eeff58..bc84d6188ca5995bba7a2e2b004ad6ab5ab19752 100644
--- a/content/browser/devtools/devtools_agent_host_impl.h
+++ b/content/browser/devtools/devtools_agent_host_impl.h
@@ -18,6 +18,8 @@ class Message;
namespace content {
+class NavigationEntry;
+
// Describes interface for managing devtools agents from the browser process.
class CONTENT_EXPORT DevToolsAgentHostImpl : public DevToolsAgentHost {
public:
@@ -41,9 +43,19 @@ class CONTENT_EXPORT DevToolsAgentHostImpl : public DevToolsAgentHost {
close_listener_ = listener;
}
- int id() { return id_; }
-
// DevToolsAgentHost implementation.
+ virtual int id() OVERRIDE { return id_; }
+
+ virtual bool attached() OVERRIDE;
+
+ virtual std::string title() OVERRIDE;
+
+ virtual GURL url() OVERRIDE;
+
+ virtual GURL thumbnail_url() OVERRIDE;
+
+ virtual GURL favicon_url() OVERRIDE;
+
virtual RenderViewHost* GetRenderViewHost() OVERRIDE;
protected:
@@ -60,6 +72,9 @@ class CONTENT_EXPORT DevToolsAgentHostImpl : public DevToolsAgentHost {
private:
int id_;
+
+ WebContents* GetWebContents();
pfeldman 2013/03/01 08:49:30 These should only be in render_view_devtools_agent
Vladislav Kaznacheev 2013/03/01 12:58:35 Done.
+ NavigationEntry* GetNavigationEntry();
};
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698