Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7057)

Unified Diff: chrome/test/data/extensions/api_test/debugger/background.js

Issue 12319114: Extract debugger target enumeration into a separate class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@debugger
Patch Set: Cleaner version ready for review Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/extensions/api_test/debugger/background.js
diff --git a/chrome/test/data/extensions/api_test/debugger/background.js b/chrome/test/data/extensions/api_test/debugger/background.js
index d68ed6b02ea831aa9875cc418eda0f4bc38e94b0..f380731adb3eca41aca05bf24b68e2ee95de75c2 100644
--- a/chrome/test/data/extensions/api_test/debugger/background.js
+++ b/chrome/test/data/extensions/api_test/debugger/background.js
@@ -111,5 +111,35 @@ chrome.test.runTests([
chrome.debugger.attach(debuggeeExtension, protocolVersion,
fail("Cannot attach to an extension unless " +
"'silent-debugger-extension-api' flag is enabled."));
+ },
+
+ function createAndDiscoverTab() {
+ chrome.tabs.create({url:"inspected.html"}, function() {
+ chrome.debugger.getTargets(function(targets) {
+ var page = targets.filter(
+ function(t) {
+ return t.type == 'page' && t.title == 'Test page';
+ })[0];
+ if (page) {
+ chrome.debugger.attach({targetId: page.id}, protocolVersion, pass());
+ } else {
+ chrome.test.fail("Cannot discover a newly created tab");
+ }
+ });
+ });
+ },
+
+ function discoverExtensionWithNoSilentFlag() {
+ chrome.debugger.getTargets(function(targets) {
+ var target = targets.filter(
+ function(target) { return target.type == 'extension'})[0];
+ if (target) {
+ chrome.debugger.attach({targetId: target.id}, protocolVersion,
+ fail("Cannot attach to an extension unless " +
+ "'silent-debugger-extension-api' flag is enabled."));
+ } else {
+ chrome.test.succeed();
+ }
+ });
}
]);

Powered by Google App Engine
This is Rietveld 408576698