Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1098)

Unified Diff: content/browser/devtools/devtools_agent_host_impl.h

Issue 12319114: Extract debugger target enumeration into a separate class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@debugger
Patch Set: Fixed compile Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/devtools_agent_host_impl.h
diff --git a/content/browser/devtools/devtools_agent_host_impl.h b/content/browser/devtools/devtools_agent_host_impl.h
index c3a52155f91294dd70f9fa3cab7d31f258eeff58..4eecbf2b486cb05194c375e1cb1fe4e40a708356 100644
--- a/content/browser/devtools/devtools_agent_host_impl.h
+++ b/content/browser/devtools/devtools_agent_host_impl.h
@@ -41,11 +41,17 @@ class CONTENT_EXPORT DevToolsAgentHostImpl : public DevToolsAgentHost {
close_listener_ = listener;
}
- int id() { return id_; }
-
// DevToolsAgentHost implementation.
+ virtual std::string GetId() OVERRIDE { return id_; }
+
virtual RenderViewHost* GetRenderViewHost() OVERRIDE;
+ virtual std::string GetTitle() OVERRIDE;
+
+ virtual GURL GetUrl() OVERRIDE;
+
+ virtual GURL GetFaviconUrl() OVERRIDE;
+
protected:
DevToolsAgentHostImpl();
virtual ~DevToolsAgentHostImpl() {}
@@ -59,7 +65,7 @@ class CONTENT_EXPORT DevToolsAgentHostImpl : public DevToolsAgentHost {
CloseListener* close_listener_;
private:
- int id_;
+ const std::string id_;
};
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698