Extract debugger target enumeration into a separate class

content/browser/devtools/render_view_devtools_agent_host.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/devtools/render_view_devtools_agent_host.h"
 
 #include "base/base64.h"
 #include "base/basictypes.h"
 #include "base/lazy_instance.h"
+#include "base/utf_string_conversions.h"
 #include "content/browser/child_process_security_policy_impl.h"
 #include "content/browser/devtools/devtools_manager_impl.h"
 #include "content/browser/devtools/devtools_protocol.h"
 #include "content/browser/devtools/renderer_overrides_handler.h"
 #include "content/browser/renderer_host/render_process_host_impl.h"
 #include "content/browser/renderer_host/render_view_host_impl.h"
 #include "content/browser/site_instance_impl.h"
 #include "content/browser/web_contents/web_contents_impl.h"
 #include "content/common/devtools_messages.h"
 #include "content/public/browser/content_browser_client.h"
+#include "content/public/browser/favicon_status.h"
+#include "content/public/browser/navigation_entry.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/notification_types.h"
 #include "content/public/browser/render_widget_host_view.h"
+#include "net/base/escape.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebDevToolsAgent.h"
 #include "ui/gfx/image/image_skia.h"
 #include "ui/gfx/native_widget_types.h"
 #include "ui/snapshot/snapshot.h"
 
 
 namespace content {
 
 typedef std::vector<RenderViewDevToolsAgentHost*> Instances;
 
@@ skipping 107 matching lines @@
   g_instances.Get().push_back(this);
   RenderViewHostDelegate* delegate = render_view_host_->GetDelegate();
   if (delegate && delegate->GetAsWebContents())
     Observe(delegate->GetAsWebContents());
 }
 
 RenderViewHost* RenderViewDevToolsAgentHost::GetRenderViewHost() {
   return render_view_host_;
 }
 
+std::string RenderViewDevToolsAgentHost::title() {
+  WebContents* web_contents =
+      GetRenderViewHost()->GetDelegate()->GetAsWebContents();

[pfeldman, 2013/03/01 14:28:17]

Here and below: when RVH dies, this AgentHost is still alive. You should
explicitly check render_view_host_ for being NULL (and use render_view_host_
directly!)

[Vladislav Kaznacheev, 2013/03/01 16:16:38]

Done.

+  if (!web_contents)
+    return "";
+
+  return UTF16ToUTF8(net::EscapeForHTML(web_contents->GetTitle()));
+}
+
+GURL RenderViewDevToolsAgentHost::url() {
+   return GetRenderViewHost()->GetDelegate()->GetURL();
+}
+
+GURL RenderViewDevToolsAgentHost::thumbnail_url() {
+  NavigationEntry* entry = GetNavigationEntry();
+  if (!entry)
+    return GURL();
+
+  return GURL("/thumb/" + entry->GetURL().spec());
+}
+
+GURL RenderViewDevToolsAgentHost::favicon_url() {
+  NavigationEntry* entry = GetNavigationEntry();
+  if (!entry)
+    return GURL();
+
+  return entry->GetFavicon().url;
+}
+
 void RenderViewDevToolsAgentHost::DispatchOnInspectorBackend(
     const std::string& message) {
   std::string error_message;
   scoped_ptr<DevToolsProtocol::Command> command(
       DevToolsProtocol::ParseCommand(message, &error_message));
   if (!command) {
     OnDispatchOnInspectorFrontend(error_message);
     return;
   }
 
@@ skipping 179 matching lines @@
                             &png,
                             snapshot_bounds))
     return false;
 
   return base::Base64Encode(base::StringPiece(
                                 reinterpret_cast<char*>(&*png.begin()),
                                 png.size()),
                             base_64_data);
 }
 
+NavigationEntry* RenderViewDevToolsAgentHost::GetNavigationEntry() {
+  WebContents* web_contents =
+      GetRenderViewHost()->GetDelegate()->GetAsWebContents();
+  if (!web_contents)
+    return NULL;
+
+  NavigationController& controller = web_contents->GetController();
+  NavigationEntry* entry = controller.GetActiveEntry();
+  if (!entry || !entry->GetURL().is_valid())
+    return NULL;
+
+  return entry;
+}
+
 }  // namespace content