Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 12319111: Fix bogus regexp test. (Closed)

Created:
7 years, 10 months ago by Yang
Modified:
7 years, 10 months ago
Reviewers:
dcarney
CC:
v8-dev, ulan
Visibility:
Public.

Description

Fix bogus regexp test. The reason this test fails on ARM hardware but not on Intel hardware (including the ARM simulator) is this: '\xa0' is interpreted as a negative signed byte number. Casting it to uc16 sign-extends it. The resulting string does not fit into a one-byte string, thus a two-byte string is allocated. For some reason the code compiled for ARM does not sign-extend, and 0xa0 fits into a one-byte string. Thus a one-byte string is allocated. Trying to cast it to two-byte causes assertion failure. BUG= Committed: https://code.google.com/p/v8/source/detail?r=13729

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M test/cctest/test-regexp.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
7 years, 10 months ago (2013-02-26 10:46:32 UTC) #1
drcarney
lgtm
7 years, 10 months ago (2013-02-26 10:48:56 UTC) #2
Yang
7 years, 10 months ago (2013-02-26 10:50:05 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r13729 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698