Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Side by Side Diff: content/browser/web_contents/web_contents_impl.h

Issue 12319035: Avoid creating an extra RVH for a tab's opener when one is pending. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Initial patch Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | content/browser/web_contents/web_contents_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_ 5 #ifndef CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
6 #define CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_ 6 #define CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
7 7
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <string> 10 #include <string>
(...skipping 462 matching lines...) Expand 10 before | Expand all | Expand 10 after
473 const NotificationDetails& details) OVERRIDE; 473 const NotificationDetails& details) OVERRIDE;
474 474
475 475
476 private: 476 private:
477 friend class NavigationControllerImpl; 477 friend class NavigationControllerImpl;
478 friend class WebContentsObserver; 478 friend class WebContentsObserver;
479 friend class WebContents; // To implement factory methods. 479 friend class WebContents; // To implement factory methods.
480 480
481 FRIEND_TEST_ALL_PREFIXES(WebContentsImplTest, NoJSMessageOnInterstitials); 481 FRIEND_TEST_ALL_PREFIXES(WebContentsImplTest, NoJSMessageOnInterstitials);
482 FRIEND_TEST_ALL_PREFIXES(WebContentsImplTest, UpdateTitle); 482 FRIEND_TEST_ALL_PREFIXES(WebContentsImplTest, UpdateTitle);
483 FRIEND_TEST_ALL_PREFIXES(WebContentsImplTest, FindOpenerRVHWhenPending);
483 FRIEND_TEST_ALL_PREFIXES(WebContentsImplTest, 484 FRIEND_TEST_ALL_PREFIXES(WebContentsImplTest,
484 CrossSiteCantPreemptAfterUnload); 485 CrossSiteCantPreemptAfterUnload);
485 FRIEND_TEST_ALL_PREFIXES(FormStructureBrowserTest, HTMLFiles); 486 FRIEND_TEST_ALL_PREFIXES(FormStructureBrowserTest, HTMLFiles);
486 FRIEND_TEST_ALL_PREFIXES(NavigationControllerTest, HistoryNavigate); 487 FRIEND_TEST_ALL_PREFIXES(NavigationControllerTest, HistoryNavigate);
487 FRIEND_TEST_ALL_PREFIXES(RenderViewHostManagerTest, PageDoesBackAndReload); 488 FRIEND_TEST_ALL_PREFIXES(RenderViewHostManagerTest, PageDoesBackAndReload);
488 489
489 // So InterstitialPageImpl can access SetIsLoading. 490 // So InterstitialPageImpl can access SetIsLoading.
490 friend class InterstitialPageImpl; 491 friend class InterstitialPageImpl;
491 492
492 // TODO(brettw) TestWebContents shouldn't exist! 493 // TODO(brettw) TestWebContents shouldn't exist!
(...skipping 397 matching lines...) Expand 10 before | Expand all | Expand 10 after
890 // Maps the ids of pending favicon downloads to their callbacks 891 // Maps the ids of pending favicon downloads to their callbacks
891 typedef std::map<int, FaviconDownloadCallback> FaviconDownloadMap; 892 typedef std::map<int, FaviconDownloadCallback> FaviconDownloadMap;
892 FaviconDownloadMap favicon_download_map_; 893 FaviconDownloadMap favicon_download_map_;
893 894
894 DISALLOW_COPY_AND_ASSIGN(WebContentsImpl); 895 DISALLOW_COPY_AND_ASSIGN(WebContentsImpl);
895 }; 896 };
896 897
897 } // namespace content 898 } // namespace content
898 899
899 #endif // CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_ 900 #endif // CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
OLDNEW
« no previous file with comments | « no previous file | content/browser/web_contents/web_contents_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698