Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12319031: Display Page Launcher icons in gtk. (Closed)

Created:
7 years, 10 months ago by Rune Fevang
Modified:
7 years, 10 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Display Page Launcher icons in gtk. BUG=125307 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183665

Patch Set 1 #

Total comments: 10

Patch Set 2 : Estade comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -1 line) Patch
M chrome/browser/ui/gtk/action_box_button_gtk.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/gtk/action_box_button_gtk.cc View 1 2 chunks +97 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Rune Fevang
7 years, 10 months ago (2013-02-20 21:56:10 UTC) #1
Evan Stade
lgtm https://codereview.chromium.org/12319031/diff/1/chrome/browser/ui/gtk/action_box_button_gtk.cc File chrome/browser/ui/gtk/action_box_button_gtk.cc (right): https://codereview.chromium.org/12319031/diff/1/chrome/browser/ui/gtk/action_box_button_gtk.cc#newcode31 chrome/browser/ui/gtk/action_box_button_gtk.cc:31: namespace { \n https://codereview.chromium.org/12319031/diff/1/chrome/browser/ui/gtk/action_box_button_gtk.cc#newcode44 chrome/browser/ui/gtk/action_box_button_gtk.cc:44: ~ExtensionIcon() {} destructor ...
7 years, 10 months ago (2013-02-20 22:02:44 UTC) #2
Rune Fevang
https://codereview.chromium.org/12319031/diff/1/chrome/browser/ui/gtk/action_box_button_gtk.cc File chrome/browser/ui/gtk/action_box_button_gtk.cc (right): https://codereview.chromium.org/12319031/diff/1/chrome/browser/ui/gtk/action_box_button_gtk.cc#newcode31 chrome/browser/ui/gtk/action_box_button_gtk.cc:31: namespace { On 2013/02/20 22:02:44, Evan Stade wrote: > ...
7 years, 10 months ago (2013-02-20 22:17:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rfevang@chromium.org/12319031/3002
7 years, 10 months ago (2013-02-20 22:17:27 UTC) #4
commit-bot: I haz the power
7 years, 10 months ago (2013-02-21 00:06:09 UTC) #5
Message was sent while issue was closed. 
Change committed as 183665

Powered by Google App Engine
This is Rietveld 408576698