Add a dialog for getting user consent in the echo redeem flow.

chrome/browser/ui/views/echo_dialog_views_chromeos.h

+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_VIEWS_ECHO_DIALOG_VIEWS_CHROMEOS_H_
+#define CHROME_BROWSER_UI_VIEWS_ECHO_DIALOG_VIEWS_CHROMEOS_H_
+
+#include "base/memory/scoped_ptr.h"

[tfarina, 2013/02/26 19:16:49]

you don't need this include, instead include basictypes for DISALLOW macro and
compiler_specific for OVERRIDE

[tbarzic, 2013/02/26 19:34:55]

Done.

+#include "chrome/browser/ui/echo_dialog_chromeos.h"
+#include "ui/views/controls/link_listener.h"
+#include "ui/views/window/dialog_delegate.h"
+
+namespace views {
+class EchoDialogListener;

[tfarina, 2013/02/26 19:13:00]

remove this.

[tbarzic, 2013/02/26 19:34:55]

Done.

+class Link;

[tfarina, 2013/02/26 19:16:49]

you don't need this forward declaration either, bcz it's part of link_listener.h
API.

[tbarzic, 2013/02/26 19:34:55]

Done.

+}
+
+namespace views {

[tfarina, 2013/02/26 19:16:49]

also, no namespace. This isn't in ui/views/ so we don't put classes under
c/b/ui/views under views namespace.

[tbarzic, 2013/02/26 19:34:55]

Done.

+
+class EchoDialogView : public EchoDialog,
+                       public views::DialogDelegateView,
+                       public views::LinkListener {
+ public:
+  explicit EchoDialogView(EchoDialog::Listener* listener);
+  virtual ~EchoDialogView();
+
+  // EchoDialog overrides.

[tfarina, 2013/02/26 19:16:49]

Can you make those overrides private?

[tbarzic, 2013/02/26 19:34:55]

Done.

+  virtual void InitForEnabledEcho(const string16& service_name,
+                                  const string16& origin) OVERRIDE;
+  virtual void InitForDisabledEcho() OVERRIDE;
+  virtual void Show(gfx::NativeWindow parent) OVERRIDE;
+
+  // views::DialogDelegate overrides.
+  virtual int GetDialogButtons() const OVERRIDE;
+  virtual int GetDefaultDialogButton() const OVERRIDE;
+  virtual string16 GetDialogButtonLabel(ui::DialogButton button) const OVERRIDE;
+  virtual bool Cancel() OVERRIDE;
+  virtual bool Accept() OVERRIDE;
+
+  // views::WidgetDelegate overrides.
+  virtual ui::ModalType GetModalType() const OVERRIDE;
+  virtual bool ShouldShowWindowTitle() const OVERRIDE;
+  virtual bool ShouldShowWindowIcon() const OVERRIDE;
+
+  // views::LinkListener override.
+  // Observes "More info" link in the dialog content.

[tfarina, 2013/02/26 19:16:49]

do you need this comment? I think it's redundant.

[tbarzic, 2013/02/26 19:34:55]

Done.

+  virtual void LinkClicked(views::Link* source, int event_flags) OVERRIDE;
+
+ private:
+  EchoDialog::Listener* listener_;
+  int ok_button_label_id_;
+  int cancel_button_label_id_;
+
+  DISALLOW_COPY_AND_ASSIGN(EchoDialogView);
+};
+
+}  // namespace views
+
+#endif  // CHROME_BROWSER_UI_VIEWS_ECHO_DIALOG_VIEWS_CHROMEOS_H_
+