Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Unified Diff: sync/engine/sync_session_job.cc

Issue 12317104: Remove canary member from SyncSessionJob (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/engine/sync_session_job.h ('k') | sync/engine/sync_session_job_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/engine/sync_session_job.cc
diff --git a/sync/engine/sync_session_job.cc b/sync/engine/sync_session_job.cc
index adf898e26fc907898b7278cff32cf5d920519207..f18e010762a0b3294f906b3511f04a7313151b95 100644
--- a/sync/engine/sync_session_job.cc
+++ b/sync/engine/sync_session_job.cc
@@ -20,7 +20,6 @@ SyncSessionJob::SyncSessionJob(
: purpose_(purpose),
scheduled_start_(start),
session_(session.Pass()),
- is_canary_(false),
config_params_(config_params),
finished_(NOT_FINISHED) {
}
@@ -104,10 +103,6 @@ scoped_ptr<sessions::SyncSession> SyncSessionJob::CloneSession() const {
session_->delegate(), session_->source()));
}
-bool SyncSessionJob::is_canary() const {
- return is_canary_;
-}
-
SyncSessionJob::Purpose SyncSessionJob::purpose() const {
return purpose_;
}
@@ -132,12 +127,6 @@ ConfigurationParams SyncSessionJob::config_params() const {
return config_params_;
}
-void SyncSessionJob::GrantCanaryPrivilege() {
- DCHECK_EQ(finished_, NOT_FINISHED);
- DVLOG(2) << "Granting canary priviliege to " << session_.get();
- is_canary_ = true;
-}
-
SyncerStep SyncSessionJob::start_step() const {
SyncerStep start, end;
GetSyncerStepsForPurpose(purpose_, &start, &end);
« no previous file with comments | « sync/engine/sync_session_job.h ('k') | sync/engine/sync_session_job_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698