Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 12317098: Android: allow host OS to be passed to envsetup. (Closed)

Created:
7 years, 10 months ago by Torne
Modified:
7 years, 10 months ago
Reviewers:
Yaron
CC:
chromium-reviews, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org
Visibility:
Public.

Description

Android: allow host OS to be passed to envsetup. For the WebView build we need to support building on Mac, after generating the makefiles on Linux. Add an option to envsetup.sh to override the detected host OS. The Android build system handles the actual logic of knowing how to build host binaries on mac, so this is the only change that's needed (to get V8 to use the right value of host_os in gyp). BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184449

Patch Set 1 #

Total comments: 1

Patch Set 2 : Update usage #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M build/android/envsetup.sh View 1 chunk +0 lines, -2 lines 0 comments Download
M build/android/envsetup_functions.sh View 1 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Torne
Hi Yaron, a simple one ;)
7 years, 10 months ago (2013-02-25 16:12:13 UTC) #1
Yaron
lgtm So are you generating different makefiles, one for linux and one for mac? The ...
7 years, 10 months ago (2013-02-25 16:32:43 UTC) #2
Torne
On 2013/02/25 16:32:43, Yaron wrote: > lgtm > > So are you generating different makefiles, ...
7 years, 10 months ago (2013-02-25 16:43:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/torne@chromium.org/12317098/5001
7 years, 10 months ago (2013-02-25 16:50:13 UTC) #4
commit-bot: I haz the power
7 years, 10 months ago (2013-02-25 18:43:44 UTC) #5
Message was sent while issue was closed.
Change committed as 184449

Powered by Google App Engine
This is Rietveld 408576698