Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 12317040: Fix Android x86 release official build. (Closed)

Created:
7 years, 10 months ago by shashi
Modified:
7 years, 10 months ago
Reviewers:
Yaron, kerz_chromium
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix Android x86 release official build. Android toolchain linker does not support --no-keep-files-mapped flag. Add a gyp condition to disable this flag for Android. BUG=177400 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183828

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
shashi
7 years, 10 months ago (2013-02-21 04:40:09 UTC) #1
Yaron
lgtm
7 years, 10 months ago (2013-02-21 04:56:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shashishekhar@chromium.org/12317040/1
7 years, 10 months ago (2013-02-21 05:10:26 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=113924
7 years, 10 months ago (2013-02-21 06:29:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shashishekhar@chromium.org/12317040/1
7 years, 10 months ago (2013-02-21 07:58:13 UTC) #5
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_testsnet_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=101345
7 years, 10 months ago (2013-02-21 08:39:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shashishekhar@chromium.org/12317040/1
7 years, 10 months ago (2013-02-21 16:25:05 UTC) #7
commit-bot: I haz the power
7 years, 10 months ago (2013-02-21 17:20:17 UTC) #8
Message was sent while issue was closed.
Change committed as 183828

Powered by Google App Engine
This is Rietveld 408576698