Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 12317036: Add API in developerPrivate to allow/ disallow incognito mode. (Closed)

Created:
7 years, 10 months ago by Gaurav
Modified:
7 years, 9 months ago
CC:
chromium-reviews, Aaron Boodman, arv+watch_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Add API in developerPrivate to allow/ disallow incognito mode. BUG=149036 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184523

Patch Set 1 #

Patch Set 2 : . #

Total comments: 6

Patch Set 3 : comments #

Total comments: 2

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -1 line) Patch
M chrome/browser/extensions/api/developer_private/developer_private_api.h View 1 2 3 1 chunk +12 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/developer_private/developer_private_api.cc View 1 2 3 1 chunk +23 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_function_histogram_value.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/apps_debugger/js/items_list.js View 1 2 3 2 chunks +23 lines, -0 lines 0 comments Download
M chrome/browser/resources/apps_debugger/main.html View 1 2 3 1 chunk +6 lines, -1 line 0 comments Download
M chrome/common/extensions/api/developer_private.idl View 1 2 3 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Gaurav
@antony: Files developer_private* @dbeam: Files main.html, items_list.js
7 years, 10 months ago (2013-02-21 00:32:01 UTC) #1
Dan Beam
lgtm https://codereview.chromium.org/12317036/diff/2001/chrome/browser/resources/apps_debugger/js/items_list.js File chrome/browser/resources/apps_debugger/js/items_list.js (right): https://codereview.chromium.org/12317036/diff/2001/chrome/browser/resources/apps_debugger/js/items_list.js#newcode311 chrome/browser/resources/apps_debugger/js/items_list.js:311: var incognito = el.querySelector('.incognito-control'); nit: put this inside ...
7 years, 10 months ago (2013-02-21 01:14:28 UTC) #2
asargent_no_longer_on_chrome
https://codereview.chromium.org/12317036/diff/2001/chrome/browser/extensions/api/developer_private/developer_private_api.cc File chrome/browser/extensions/api/developer_private/developer_private_api.cc (right): https://codereview.chromium.org/12317036/diff/2001/chrome/browser/extensions/api/developer_private/developer_private_api.cc#newcode428 chrome/browser/extensions/api/developer_private/developer_private_api.cc:428: SetResult(Value::CreateBooleanValue(result)); nit: instead of a boolean result passed as ...
7 years, 10 months ago (2013-02-22 00:04:06 UTC) #3
Gaurav
https://codereview.chromium.org/12317036/diff/2001/chrome/browser/extensions/api/developer_private/developer_private_api.cc File chrome/browser/extensions/api/developer_private/developer_private_api.cc (right): https://codereview.chromium.org/12317036/diff/2001/chrome/browser/extensions/api/developer_private/developer_private_api.cc#newcode428 chrome/browser/extensions/api/developer_private/developer_private_api.cc:428: SetResult(Value::CreateBooleanValue(result)); On 2013/02/22 00:04:06, Antony Sargent wrote: > nit: ...
7 years, 9 months ago (2013-02-25 18:26:50 UTC) #4
asargent_no_longer_on_chrome
LGTM Can you file a bug to change other instances of BooleanCallback to VoidCallback where ...
7 years, 9 months ago (2013-02-25 18:40:30 UTC) #5
Gaurav
On 2013/02/25 18:40:30, Antony Sargent wrote: > LGTM > > Can you file a bug ...
7 years, 9 months ago (2013-02-25 19:32:33 UTC) #6
Gaurav
https://codereview.chromium.org/12317036/diff/5002/chrome/browser/extensions/api/developer_private/developer_private_api.cc File chrome/browser/extensions/api/developer_private/developer_private_api.cc (right): https://codereview.chromium.org/12317036/diff/5002/chrome/browser/extensions/api/developer_private/developer_private_api.cc#newcode428 chrome/browser/extensions/api/developer_private/developer_private_api.cc:428: return true; On 2013/02/25 18:40:30, Antony Sargent wrote: > ...
7 years, 9 months ago (2013-02-25 21:43:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grv@chromium.org/12317036/7003
7 years, 9 months ago (2013-02-25 21:45:11 UTC) #8
commit-bot: I haz the power
7 years, 9 months ago (2013-02-26 00:18:48 UTC) #9
Message was sent while issue was closed.
Change committed as 184523

Powered by Google App Engine
This is Rietveld 408576698