Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 12317015: [android_webview] Add test shell for webview. (Closed)

Created:
7 years, 10 months ago by mkosiba (inactive)
Modified:
7 years, 9 months ago
Reviewers:
joth, benm (inactive)
CC:
chromium-reviews, android-webview-reviews_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, klundberg+watch_chromium.org, ilevy+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

[android_webview] Add test shell for webview. This adds a simple test shell (most code stolen from chrome testshell) for android_webview testing. The only currently supported rendering mode is s/w rendering. BUG=None Android_webview-only change, ran through trybots. NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=189246

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Total comments: 6

Patch Set 6 : rebase #

Patch Set 7 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+246 lines, -110 lines) Patch
M android_webview/android_webview_tests.gypi View 1 2 3 4 5 2 chunks +37 lines, -5 lines 0 comments Download
M android_webview/javatests/AndroidManifest.xml View 1 1 chunk +0 lines, -25 lines 0 comments Download
D android_webview/javatests/assets/asset_file.html View 1 1 chunk +0 lines, -8 lines 0 comments Download
D android_webview/javatests/assets/asset_icon.png View 1 0 chunks +-1 lines, --1 lines 0 comments Download
D android_webview/javatests/assets/full_screen_video_test.html View 1 2 3 4 5 1 chunk +0 lines, -26 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AndroidWebViewTestBase.java View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
D android_webview/javatests/src/org/chromium/android_webview/test/AndroidWebViewTestRunnerApplication.java View 1 chunk +0 lines, -31 lines 0 comments Download
D android_webview/javatests/src/org/chromium/android_webview/test/AwTestContainerView.java View 1 1 chunk +1 line, -1 line 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwTestResourceProvider.java View 1 1 chunk +1 line, -1 line 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/NullContentsClient.java View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
A android_webview/shell_apk/AndroidManifest.xml View 1 2 3 1 chunk +27 lines, -0 lines 0 comments Download
A + android_webview/shell_apk/res/layout/testshell_activity.xml View 1 3 chunks +10 lines, -11 lines 0 comments Download
A android_webview/shell_apk/src/org/chromium/android_webview/shell/AndroidWebViewTestShellActivity.java View 1 2 3 4 5 1 chunk +162 lines, -0 lines 0 comments Download
A + android_webview/shell_apk/src/org/chromium/android_webview/shell/AndroidWebViewTestShellApplication.java View 1 2 3 4 5 2 chunks +6 lines, -2 lines 0 comments Download
A + android_webview/test_apk/AndroidManifest.xml View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + android_webview/test_apk/assets/asset_file.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + android_webview/test_apk/assets/full_screen_video_test.html View 1 2 3 4 5 0 chunks +-1 lines, --1 lines 0 comments Download
A + android_webview/test_apk/src/org/chromium/android_webview/test/AndroidWebViewTestRunnerApplication.java View 1 1 chunk +2 lines, -0 lines 0 comments Download
A + build/android/adb_run_android_webview_shell View 1 2 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
mkosiba (inactive)
7 years, 10 months ago (2013-02-20 18:06:22 UTC) #1
mkosiba (inactive)
PTAL
7 years, 9 months ago (2013-03-12 14:56:20 UTC) #2
mkosiba (inactive)
Ping?
7 years, 9 months ago (2013-03-14 15:23:25 UTC) #3
mkosiba (inactive)
ping ping ping?
7 years, 9 months ago (2013-03-19 11:21:29 UTC) #4
benm (inactive)
https://chromiumcodereview.appspot.com/12317015/diff/15001/android_webview/android_webview_tests.gypi File android_webview/android_webview_tests.gypi (right): https://chromiumcodereview.appspot.com/12317015/diff/15001/android_webview/android_webview_tests.gypi#newcode33 android_webview/android_webview_tests.gypi:33: 'is_test_apk': 0, # We want resources from android_webview_test_java. We ...
7 years, 9 months ago (2013-03-19 12:55:01 UTC) #5
mkosiba (inactive)
https://codereview.chromium.org/12317015/diff/15001/android_webview/android_webview_tests.gypi File android_webview/android_webview_tests.gypi (right): https://codereview.chromium.org/12317015/diff/15001/android_webview/android_webview_tests.gypi#newcode33 android_webview/android_webview_tests.gypi:33: 'is_test_apk': 0, # We want resources from android_webview_test_java. On ...
7 years, 9 months ago (2013-03-19 17:11:26 UTC) #6
benm (inactive)
lgtm thanks! Sorry for the delay in looking over this!
7 years, 9 months ago (2013-03-19 19:03:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkosiba@chromium.org/12317015/27001
7 years, 9 months ago (2013-03-20 10:43:29 UTC) #8
commit-bot: I haz the power
7 years, 9 months ago (2013-03-20 12:06:54 UTC) #9
Message was sent while issue was closed.
Change committed as 189246

Powered by Google App Engine
This is Rietveld 408576698