Insert conversion to string in string.replace.

test/mjsunit/string-replace.js

 // Copyright 2009 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 198 matching lines @@
             "abaz", /a(.)/g, replacer);
 
 var str = 'She sells seashells by the seashore.';
 var re = /sh/g;
 assertEquals('She sells sea$schells by the sea$schore.',
              str.replace(re,"$$" + 'sch'))
 
 
 var replace_obj = { length: 0, toString: function() { return "x"; }};
 assertEquals("axc", "abc".replace(/b/, replace_obj));
+assertEquals("axc", "abc".replace(/b/g, replace_obj));
 
 var search_obj = { length: 1, toString: function() { return "b"; }};
 assertEquals("axc", "abc".replace(search_obj, function() { return "x"; }));
 
+var side_effect_flag = false;
+var replace_obj_side_effects = { 
+    toString: function() { side_effect_flag = true; return "x" }
+}
+assertEquals("abc", "abc".replace(/z/g, function() { return "x"; }));
+assertTrue(side_effect_flag);  // Side effect triggers even without a match.
+
 var regexp99pattern = "";
 var subject = "";
 for (var i = 0; i < 99; i++) {
   regexp99pattern += "(.)";
   subject += String.fromCharCode(i + 24);
 }
 
 function testIndices99(re) {
   // Test $1 .. $99
   for (var i = 1; i < 100; i++) {
@@ skipping 25 matching lines @@
   // followed by "0", $61 as $6, followed by "1" and so on.
   var tail = subject.substr(59);
   for (var i = 60; i < 100; i++) {
     assertEquals(String.fromCharCode(i / 10 + 23) + (i % 10) + tail,
                  subject.replace(re, "$" + i));
   }
 }
 
 testIndices59(new RegExp(regexp59pattern));
 testIndices59(new RegExp(regexp59pattern, "g"));