Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 12316158: Insert conversion to string in string.replace. (Closed)

Created:
7 years, 9 months ago by Yang
Modified:
7 years, 9 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Insert conversion to string in string.replace. (missing since r13761) R=ulan@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=13766

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M src/string.js View 2 chunks +2 lines, -1 line 0 comments Download
M test/mjsunit/string-replace.js View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
7 years, 9 months ago (2013-02-27 15:10:53 UTC) #1
ulan
lgtm
7 years, 9 months ago (2013-02-27 15:11:51 UTC) #2
Yang
7 years, 9 months ago (2013-02-27 15:12:36 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r13766 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698