Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 12316136: Small non-essential fixes around the code. (Closed)

Created:
7 years, 10 months ago by sergeygs
Modified:
7 years, 9 months ago
Reviewers:
brettw, sky
CC:
chromium-reviews, sadrul, ben+watch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, erikwright+watch_chromium.org
Visibility:
Public.

Description

Small fixes around the code 1) Missing member initialization in constructor. 2) More explicit evaluation precedence in an expression. 3) Typos in comments. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186355

Patch Set 1 #

Patch Set 2 : Reconciled commits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M ash/accelerators/accelerator_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/move.h View 3 chunks +6 lines, -6 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
sergeygs1
Please review -- very low priority.
7 years, 10 months ago (2013-02-26 20:12:03 UTC) #1
miket_OOO
lgtm
7 years, 10 months ago (2013-02-26 20:19:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeygs@chromium.org/12316136/5
7 years, 10 months ago (2013-02-26 21:29:27 UTC) #3
commit-bot: I haz the power
Presubmit check for 12316136-5 failed and returned exit status 1. INFO:root:Found 3 file(s). Running presubmit ...
7 years, 10 months ago (2013-02-26 21:29:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeygs@chromium.org/12316136/5
7 years, 10 months ago (2013-02-26 22:03:33 UTC) #5
commit-bot: I haz the power
Presubmit check for 12316136-5 failed and returned exit status 1. INFO:root:Found 3 file(s). Running presubmit ...
7 years, 10 months ago (2013-02-26 22:03:38 UTC) #6
sergeygs
Please review. This is very trivial, should take 1 minute of your time. Thanks.
7 years, 9 months ago (2013-03-04 23:51:16 UTC) #7
brettw
lgtm
7 years, 9 months ago (2013-03-05 00:46:53 UTC) #8
sky
LGTM
7 years, 9 months ago (2013-03-05 03:55:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeygs@chromium.org/12316136/5
7 years, 9 months ago (2013-03-06 00:51:02 UTC) #10
commit-bot: I haz the power
7 years, 9 months ago (2013-03-06 04:23:00 UTC) #11
Message was sent while issue was closed.
Change committed as 186355

Powered by Google App Engine
This is Rietveld 408576698